Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Settings icon should have Show Sidebar options, instead of opening the Settings window

See original GitHub issue

Description

Steps to Reproduce

install 1.37.43
launch Brave
load brave://flags
set Enable Sidebar to Enabled
click to Relaunch
click on the Settings gear icon on the bottom left

Actual result:

It goes to brave://settings

Expected result:

brave://settings/?search=sidebar

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.37.43 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64)
Revision	e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS	macOS Version 11.6.1 (Build 20G224)

Issue Analytics

State:
Created 2 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

2reactions

simonhongcommented, Feb 15, 2022

@bradleyrichter @rebron How about using brave://settings/?search=sidebar for this button’s target? @stephendonner On click option will be removed via https://github.com/brave/brave-core/pull/12161

1reaction

bradleyrichtercommented, Feb 14, 2022

I think the original plan was to take the user to the sidebar settings panel in the main settings UI. Assuming we can deep link there, I think this would provide more flexibility.