Update P3A rewards enabled question to measure ads
See original GitHub issueDescription
Recently we added Brave.Rewards.EnabledDuration but there isn’t really a good definition of “Rewards Enabled”. We used to have a settings toggle for rewards overall, but it’s been removed and currently we look at a combination of ads and autocontribute opt-in settings.
@miyayes asked me to alter the measurement to just report how long ads were enabled. This is the more relevant question.
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (1 by maintainers)
Top Results From Across the Web
Fix handling of Rewards disabled state for various P3A ...
Due to recent changes to Rewards, the "Rewards disabled" bucket for several of our P3A questions is never triggered correctly.
Read more >What is P3A in Brave? - Brave Help Center
Are people using Brave Rewards? Are people using sync and if so, on how many devices? How many people still need to download...
Read more >Set up and traffic rewarded ads for apps - Google Ad Manager ...
Rewarded ad formats allow app users to receive rewards for viewing adsYou can traffic non-intrusive, ... Select the check box next to Rewarded...
Read more >Introducing Ad Verification to the Amazon Shopper Panel
Starting today, panelists have a third option for participation: Ad Verification. By choosing to enable Ad Verification, panelists allow us to confirm which...
Read more >Brave, the false sensation of privacy - Hacker News
Ads are bad, but the attention economy is the underlying problem. ... Brave Rewards enables users to self-fund, and contribute automatically ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

Thanks @rillian, I think we should rename the question just to avoid confusion (unless it introduces a lot of wrinkles).
Verification
PASSEDonSamsung S10+runningAndroid 12using the following build(s):Went through the STR/Cases outlined via https://github.com/brave/brave-core/pull/12371 & https://github.com/brave/brave-browser/issues/21030#issuecomment-1092057586.
Clean profile
Case 1: Ads was never ON_Brave.Rewards.AdsEnabledDuration=0_PASSED
Brave.Rewards.AdsEnabledDurationresponse value is0Case 2: Ads is still ON_Brave.Rewards.AdsEnabledDuration=1_PASSED
Brave.Rewards.AdsEnabledDurationresponse value is1Case 3: Ads was enabled less than three hours in past_Brave.Rewards.AdsEnabledDuration=2_PASSED
Case 1_enable and disable Ads in a minute
Brave.Rewards.AdsEnabledDurationresponse value is2as Ads is disabled within three hoursCase 2_disable Ads in < 3 hours
Brave.Rewards.AdsEnabledDurationresponse value is2as Ads is disabled within three hoursCase 3_disable Ads exactly at 3 hours:
Brave.Rewards.AdsEnabledDurationresponse value is3as Ads is disabled exact at 3 hoursCase 4_disable Ads after 3 hours:
Brave.Rewards.AdsEnabledDurationresponse value is3as Ads is disabled after 3 hoursCase 4: Ads was enabled less than three days in past_Brave.Rewards.AdsEnabledDuration=3_PASSED
Case 1: disable ads in < 3days
Brave.Rewards.AdsEnabledDurationresponse value is3as Ads is disabled within 3daysCase 2: disable ads exactly on the 3rd day
Brave.Rewards.AdsEnabledDurationresponse value is4as Ads is disabled on the 3rd dayCase 3: disable ads after 3days
Brave.Rewards.AdsEnabledDurationresponse value is4as Ads is disabled after 3daysCase 5: Ads was enabled less than three weeks in past_Brave.Rewards.AdsEnabledDuration=4_PASSED
Case 1: disable ads in < three weeks
Brave.Rewards.AdsEnabledDurationresponse value is4as Ads is disabled within 3 weeksCase 2: disable ads exactly on the 3rd week (21st day)
Brave.Rewards.AdsEnabledDurationresponse value is5as Ads is disabled on the 3rd weekCase 6: Ads was enabled less than three months in past_Brave.Rewards.AdsEnabledDuration=5_PASSED
Case 1: Passed
Brave.Rewards.AdsEnabledDurationresponse value is5as Ads is disabled within 3 monthsCase 2: - Passed
Brave.Rewards.AdsEnabledDurationresponse value is5as expected (Discussed with @DJAndries: 30.44 days as a “month” (that’s the average length of a month) multiply that by three and we get 91.32, so 90 days would not trigger a value of6)Case 7: Ads was enabled more than three months in past_Brave.Rewards.AdsEnabledDuration=6_PASSED
Brave.Rewards.AdsEnabledDurationresponse value is6Case 8: Reset rewards_Brave.Rewards.AdsEnabledDuration=0_PASSED
Brave.Rewards.AdsEnabledDurationresponse value is1as expectedManage Brave RewardsBrave.Rewards.AdsEnabledDurationresponse value is0as expectedUpgrade profile
Case 1: Enable Rewards and upgrade the profile_PASSED
1.37.x betabuild and enabled rewards and upgraded the profile to1.38.xand ensured that the metricsBrave.Rewards.AdsEnabledDurationresponse value is1as expectedBrave.Rewards.AdsEnabledDurationresponse value is2as expectedCase 2: Enable Rewards and disable Ad switch and then upgrade the profile_PASSED
1.37.x betabuild and enabled rewards and disable Ads switch and upgraded the profile to1.38.xand ensured that the metricsBrave.Rewards.AdsEnabledDurationresponse value is0as expectedCase 3: Enable Rewards and disable AC switch and then upgrade the profile_PASSED
1.37.x betabuild and enabled rewards and disable rewards AC switch and upgraded the profile to1.38.xand ensured that the metricsBrave.Rewards.AdsEnabledDurationresponse value is1as expectedCase 4: Enable Rewards and disable Ads and AC switches manually and then upgrade the profile_PASSED
- Install `1.37.x beta` build and enable rewards disable Ads and AC switches and upgraded the profile to `1.38.x` and ensured that the metrics `Brave.Rewards.AdsEnabledDuration` response value is `0` as expectedCase 5: Enable Rewards and reset rewards and then upgrade the profile_PASSED
- Install `1.37.x beta` build and enable rewards and reset rewards and upgraded the profile to `1.38.x` and ensured that the metrics `Brave.Rewards.AdsEnabledDuration` response value is `0` as expected