question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

SKUs environment should be configurable via brave://flags

See original GitHub issue

Test plan

  1. Fresh profile
  2. Visit brave://flags/#skus-environment
  3. On Windows and macOS, there should be a value here (Default, production, staging, development) and it should be configurable. Linux is not supported at this time
  4. Enable brave://flags/#skus-sdk - set this new value (brave://flags/#skus-environment) to development
  5. Exit the browser. Start Brave via command line making sure to add logging arguments --vmodule="*/skus/*"=1 --enable-logging=stderr
  6. Visit https://account.brave.software and log in (@bsclifton can help if basic auth is presented; creds are in 1PW4T or send a DM)
  7. Once logged in, buy VPN
  8. You should see (in the console where you started Brave) lots of JSON and output from calls which include refresh_order

There may still be environment issues preventing the credentials from being issued… but as long as the refresh_order has details, that means the environment specific part worked 😄

Description

We already have brave://flags entries for both VPN and SKU (dependent on each other for Desktop) image

  • brave://flags/#brave-vpn
  • brave://flags/#skus-sdk

But at the moment, environment is defaulting to production for an official build (otherwise, it uses development).

There is a command line flag --skus-env which accepts the following values:

  • production
  • staging
  • development

It would be great to expose this in brave://flags. If Default, we can default to production. But if overridden, it can use the chosen environment.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
bscliftoncommented, Feb 25, 2022

Updated test plan to mention just looking for refresh_order 👍 and noted about environment issues

1reaction
stephendonnercommented, Feb 23, 2022

QA-status update on this: I’ve started testing, but have run into two (related?) issues:

  1. Stripe session errors on checkout (Expired) - not 100% of the time, but more than not
  2. Neither @bsclifton nor I are seeing fetch_order_credentials from the testplan, but we are seeing refresh_order calls, as expected.

@evq has offered to help take a look; thread here: https://bravesoftware.slack.com/archives/C021S0FN3V1/p1645063771631899

Being honest and marking QA/Blocked until the above two items (and any others further) are resolved. But we have a path forward 👍

Read more comments on GitHub >

github_iconTop Results From Across the Web

How Do I Use Command Line Flags in Brave?
Quit Brave; Open Command Prompt; Enter: "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe". This will open Brave just as ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found