question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update Tor to Brave Search

See original GitHub issue

Description

For New Private Window with Tor, default search engine should be Brave Search. https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=%s

Will also need to update the New Private Window with Tor new tab page to remove reference to DuckDuckGo.

Steps to Reproduce

  1. Open New Private Window with Tor
  2. Enter search terms in the url bar. Should say Search Brave or type a URL
  3. Should go to Brave Search.

Actual result:

Currently defaults to DuckDuckGo search.

Screen Shot 2022-01-18 at 12 07 28 PM

Expected result:

See description. https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/Desktop-Private-and-TOR-Windows?node-id=942%3A19384

Screen Shot 2022-01-18 at 12 07 10 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

Target version for update 1.36.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
kjozwiakcommented, Mar 14, 2022

@brave/legacy_qa some of the cases that I ran through via https://github.com/brave/brave-core/pull/12391#issuecomment-1066151499 can be used to verify the above as well.

0reactions
btlechowskicommented, Mar 15, 2022

Verification passed on

Brave 1.36.115 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS
  • Verified the STR mentioned in the description
  • Confirmed open a TOR window displays the text as Search Brave or type a URL in the URL bar
  • Confirmed search is performed by using the Brave SE
  • Confirmed that CAPTCHA test is being done whenever searching via the Tor window
![image](https://user-images.githubusercontent.com/34715963/158485034-78e37409-094d-45ab-81f9-b1adb05d075c.png) ![image](https://user-images.githubusercontent.com/34715963/158485215-cbbc96a7-89da-466a-a495-aa9588f1041d.png) ![image](https://user-images.githubusercontent.com/34715963/158485264-7fba6103-f7a0-47a6-a5d9-0583394f822d.png)

Test Case #1 - Clean Install

  • ensured that Brave Search is the default SE for both Normal/Private windows
  • ensured that Brave Search is the default SE for Tor Windows and ensured that the .onion address is being used
    • https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q
  • ensured that https://search.brave.com/search?q= is still being used under Normal & Private windows
  • ensured that there’s no mention of DDG anywhere under the Tor window nor any images associated with DDG
  • ensured that the progress bar correctly indicates when Tor is being downloaded/connecting and connected successfully
  • ensured that Brave Search is only listed once under brave://settings/search & brave://settings/searchEngines
  • ensured that the :search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion keyword is working as expected
  • ensured that changing defaults via brave://settings/searchEngines doesn’t affect the default Tor SE (should always be Brave)

image image image image image image

Test Case #2 - Upgrade (Other SE default other than Brave Search)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Ecosia via brave://settings/search
  • ensured that Ecosia is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Ecosia is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there’s no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

image image

After - 1.36.115

image image image

Test Case #3 - Upgrade (Brave Search as default)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Brave via brave://settings/search
  • ensured that Brave is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Brave is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there’s no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

image image

After - 1.36.115

image image image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Tor (Onion) - Brave Browser
Brave.com has announced its own Tor Onion Service, providing more users with secure access to Brave. Read more about it here.
Read more >
Brave Search (Tor Onion) - Firefox Browser Add-ons
Download Brave Search (Tor Onion) for Firefox. Adds the Brave Search Tor onion site as a Firefox search engine.
Read more >
How to use Tor with Brave browser | Tech Help Knowledgebase
Private Window with Tor is available for use by default. First, download Brave browser. If you have it installed already, make sure you...
Read more >
Latest Brave browser update fixes Tor .onion DNS Leak
All that is needed to activate Tor mode in Brave is to use the shortcut Alt-Shift-N, or to select Menu > New private...
Read more >
Add Brave Search as Option for Default Search Engine?
When you are on the page of the search engine, right-click the address bar and select "Add “[website name]”. It should now be...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found