Update Tor to Brave Search
See original GitHub issueDescription
For New Private Window with Tor, default search engine should be Brave Search. https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=%s
Will also need to update the New Private Window with Tor new tab page to remove reference to DuckDuckGo.
Steps to Reproduce
- Open New Private Window with Tor
- Enter search terms in the url bar. Should say
Search Brave or type a URL
- Should go to Brave Search.
Actual result:
Currently defaults to DuckDuckGo search.
Expected result:
See description. https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/Desktop-Private-and-TOR-Windows?node-id=942%3A19384
Reproduces how often:
Easily.
Brave version (brave://version info)
Target version for update 1.36.x
Version/Channel Information:
- Can you reproduce this issue with the current release? yes
- Can you reproduce this issue with the beta channel? yes
- Can you reproduce this issue with the nightly channel? yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? n/a
- Does the issue resolve itself when disabling Brave Rewards? n/a
- Is the issue reproducible on the latest version of Chrome? n/a
Miscellaneous Information:
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (3 by maintainers)
Top Results From Across the Web
Tor (Onion) - Brave Browser
Brave.com has announced its own Tor Onion Service, providing more users with secure access to Brave. Read more about it here.
Read more >Brave Search (Tor Onion) - Firefox Browser Add-ons
Download Brave Search (Tor Onion) for Firefox. Adds the Brave Search Tor onion site as a Firefox search engine.
Read more >How to use Tor with Brave browser | Tech Help Knowledgebase
Private Window with Tor is available for use by default. First, download Brave browser. If you have it installed already, make sure you...
Read more >Latest Brave browser update fixes Tor .onion DNS Leak
All that is needed to activate Tor mode in Brave is to use the shortcut Alt-Shift-N, or to select Menu > New private...
Read more >Add Brave Search as Option for Default Search Engine?
When you are on the page of the search engine, right-click the address bar and select "Add “[website name]”. It should now be...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@brave/legacy_qa some of the cases that I ran through via https://github.com/brave/brave-core/pull/12391#issuecomment-1066151499 can be used to verify the above as well.
Verification passed on
Search Brave or type a URL
in the URL barBrave
SETest Case #1
- Clean Install.onion
address is being usedhttps://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q
https://search.brave.com/search?q=
is still being used under Normal & Private windowsbrave://settings/search
&brave://settings/searchEngines
:search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion
keyword is working as expectedTest Case #2
- Upgrade (Other SE default other than Brave Search)1.36.112
https://duckduckgo.com/?q=
as the default SEEcosia
viabrave://settings/search
Ecosia
is set as the default SE viabrave://settings/searchEngines
1.36.115
Ecosia
is still the default SE underbrave://settings/search
&brave://settings/searchEngines
brave://settings/search
&brave://settings/searchEngines
https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=
is the default SEBefore
-1.36.112
After
-1.36.115
Test Case #3
- Upgrade (Brave Search as default)1.36.112
https://duckduckgo.com/?q=
as the default SEBrave
viabrave://settings/search
Brave
is set as the default SE viabrave://settings/searchEngines
1.36.115
Brave
is still the default SE underbrave://settings/search
&brave://settings/searchEngines
brave://settings/search
&brave://settings/searchEngines
https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=
is the default SEBefore
-1.36.112
After
-1.36.115