question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tab Groups forces Bottom Bar to be disabled

See original GitHub issue

Description

Tab Groups is a great chromium feature that can be enabled in chrome://flags, and is currently being enabled automatically in Chrome.

Tab Groups in Chrome. Source: Android Police

Unfortunately, when enable this in Brave, you are no longer able to use the bottom bar. It will always be disabled, even if you try to enable it again in settings. The only way to get bottom bar again is to disabling Tab Groups related flags.

Steps to reproduce

  1. Go to brave://flags
  2. Enable the flags
    • #enable-tab-grid-layout
    • #enable-tab-to-gts-animation
    • #enable-tab-groups
    • #enable-tab-groups-continuation
    • #enable-tab-groups-ui-improvements
  3. Restart Brave twice to make sure the changes have been applied

Actual result

Tab Groups works fine, but now Brave’s bottom bar is disabled https://i.imgur.com/nZsedFc.png https://i.imgur.com/Y8POR1K.png

Expected result

Enable Tab Groups without losing Brave’s bottom bar

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

1.21.38

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional information

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
srirambvcommented, Apr 8, 2021

Verification passed on OnePlus 6T with Android 10 running 1.23.68 x64 build

  • Verified test plan from https://github.com/brave/brave-browser/issues/13904#issuecomment-797074754
  • Verified with flags enabled able to group tabs
  • Verified bottom toolbar works fine when tabs are grouped
  • Verified able to close tabs from tab group without going to tab tray
  • Verified able to reopen closed tab from group via undo button
  • Verified bottom toolbar swipe works to switch tabs. Swiping happens within tab group and between tab groups
  • Verified when swipe using bottom toolbar, coming out of tab group hides the tab group bar as well
  • Verified tab group works on private tab as well
2reactions
samartnikcommented, Mar 12, 2021

New look with both Tab Groups and bottom toolbar enabled

device-2021-03-11-124632 device-2021-03-11-124646
Read more comments on GitHub >

github_iconTop Results From Across the Web

[Updated] Want to disable Tab Groups in Chrome on Android ...
In the flag search box in Experiments, type “Enable conditional tabstrip,” and select “Disabled” in the drop-down menu.
Read more >
How to disable tab groups (but unfortunately not tab grid) that ...
Navigate to chrome://flags and do a reset all first if you've previously messed with the flags. I had to do this myself to...
Read more >
How to use and disable Chrome's new tab groups and grid ...
The good news is you can disable the grid layout and tab groups with a simple step. Enter the below link in the...
Read more >
How to Disable Tab Groups?? - Microsoft Community
Type edge://flags/ in the address bar and press Enter Locate Tab Groups flag. Change the default status from 'Enabled' to 'Disabled'
Read more >
How to remove the "Group Tabs" setting for Android?
Type Chrome://flags in url bar. Search for tabs and select disable under all the headings named Group Tabs. Last edited Mar 13, 2020....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found