P3A timestamps don't update even when value is changed
See original GitHub issueDescription
Brave.Search.DefaultEngine.4
timestamp doesn’t update even when the value is being changed
Steps to Reproduce
- Install 1.20.96 beta build
- Keep default search engine during onboarding
- Check P3A Value for
Brave.Search.DefaultEngine.4
ensure its set to 1 (Google) and sent is set to true - Make note of the timestamp
- Change default SE to Ecosia
- Check
Brave.Search.DefaultEngine.4
P3A metric, successfully updates the value to 7 - Keep browser idle for a while and check timestamp, remains same as in step 4 doesn’t update, sent is still set to
true
Actual result:
Brave.Search.DefaultEngine.4 timestamp doesn’t update even when value is being changed
Expected result:
Should update timestamp when the data is sent. If its not sent to server, sent should be set to false
Reproduces how often:
Easy
Desktop Brave version:
Brave | 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit) |
---|---|
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
OS | Windows 10 OS Version 2004 (Build 19041.746) |
Android Device details:
- Install type (ARM, x86): ARM
- Device type (Phone, Tablet, Phablet): Phone
- Android version: 10
Version/Channel Information:
- Can you reproduce this issue with the current release? NA
- Can you reproduce this issue with the beta channel? Yes
- Can you reproduce this issue with the nightly channel? Mostly
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? NA
- Does the issue resolve itself when disabling Brave Rewards? NA
- Is the issue reproducible on the latest version of Chrome? NA
Miscellaneous Information:
@GeetaSarvadnya verified and confirmed bug on Desktop
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
Updating entry WITHOUT updating timestamp - mysql
You can manually set the value of the column to its current value in the update command: UPDATE table SET x=y, timestampColumn=timestampColumn WHERE...
Read more >File modified timestamp not updating... - TechNet - Microsoft
We have already changed the value of NtfsDisableLastAccessUpdate 0 but still the timestamp not getting updated.
Read more >Use ->update() without updating timestamps - Laracasts
So I have a query that updates many hundreds of rows at a time, eg Model::where('something', '=', $something)->update(['status' => 'Unallocated']); ...
Read more >How to persist creation and update timestamps with Hibernate
When a new entity gets persisted, Hibernate gets the current timestamp from the VM and sets it as the value of the attribute...
Read more >How to calculate the timespan between tickets created to ...
THEN [Update - Timestamp] ENDIF. This attribute should return the timestamp of when the Risk Case Priority field value was changed from null ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Based on https://github.com/brave/brave-browser/issues/13927#issuecomment-775429548 and https://github.com/brave/brave-browser/issues/13927#issuecomment-826722994 closing the issue as expected.
@GeetaSarvadnya thanks for checking this - I think that this behavior is totally expected, because TS update is bound to the upload schedule and not to the value change. So it is updated every time we upload the metric