question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ad search results are not hidden

See original GitHub issue

Description

We don’t hide Ad search results in cosmetic filters when aggressive mode is on in adblock

Steps to Reproduce

  1. Go to duckduckgo.com
  2. Search for example for samsung galaxy tab
  3. Observe Ad search results Screenshot from 2021-02-03 21-33-56
  4. Turn on Trackers & ads blocked (aggresive) in shields

Actual result:

Observe Ad search results

Expected result:

There are no Ad search results

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
SergeyZhukovskycommented, Feb 9, 2021

@srirambv it’s desktop specific only. We don’t have aggressive mode in shields for Android currently.

0reactions
stephendonnercommented, Feb 16, 2021

@kjozwiak thanks, and apologies for prematurely marking, then.

Verified FIXED again using 1.21.50 with the inline testplan:

Brave 1.21.50 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)
Screen Shot 2021-02-10 at 11 17 33 AM Screen Shot 2021-02-10 at 11 17 49 AM

Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified test plan from the description Standard: image Aggressive: image


Verification passed on

Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from the description

Normal tab - Ads and trackers shield settings set to Standard: image

Normal tab - Ads and trackers shield settings set to Aggressive: image

Private tab - Ads and trackers shield settings set to Standard: image

Private tab - Ads and trackers shield settings set to Aggressive: image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Remove search ads from google search results
Remove search ads from google search results · Open Control Panel > Internet Options · Select the Connections tab · Click LAN settings....
Read more >
How to Stop Personalized Ads and Search Results in Google ...
To do this, click the settings menu (three stacked dots) in the top right of Chrome, then click Settings.
Read more >
Google Explains How To Hide A Website From Search Results
Google says the best way to hide a website from search results is with a password, but there are other options you can...
Read more >
Hidden Google results - shields - Brave Community
I have a problem with Google search results. ... Seems like Brave is viewing it as an advertisement. ... Hidden Google results.
Read more >
Digital Hide And Seek: Why Your Google Ads Aren't Showing Up
Scrambling, you go through your Google Ads account and see no ad spend, ... intend your ad to show for, and then show...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found