Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

UK English sometimes Private/Private Window is not capitalized

See original GitHub issue

Description

While testing #2147 I noticed that the capitalization of Private Window isn’t consistent across translations.

For example, here is English (US). Private/Private Window is capitalized as I would expect: hamburger menu: EN-US1

on the window: EN-US2

from Brave menu (macOS): EN-US3

right click: EN-US4

Compared to English (UK), only 2 of the 4 items above are capitalized correctly - Hamburger menu and Brave menu (macOS): EN-UK1 EN-UK4

On the window and right click, Private/Private Window is not capitalized as I would expect: EN-UK2 EN-UK3

Steps to Reproduce

Use a language other than English (US).

Launch Brave with a clean profile.
View the following places:

hamburger menu
Private Window
right click on a link to view context menu
Brave menu (macOS/Linux)

See inconsistencies across capitalization.

Actual result:

English (AU) - is similar to English UK: EN-AU1 EN-AU2 EN-AU3 EN-AU4

DE - a little different, sometimes Private isn’t capitalized, but Window is DE1 DE2 DE3 DE4

Expected result:

Consistency in capitalization for Private/Private Window

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the dev channel?
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Issue Analytics

State:
Created 4 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

petemillcommented, Nov 11, 2019

@LaurenWags with regards to other languages, I learnt (when dealing with the translations for these strings, although it would apply to many other strings we have) that different languages do not do ‘title case’. So, we’d need to take it on a case-by-case basis as to whether the translation for a specific language is was correctly translated to title-case when appropriate for that language.

I’ll amend the title of this issue to make it clear that it only applies to UK English.

1reaction

bscliftoncommented, Nov 11, 2019

@LaurenWags that is correct! 😄

Top Results From Across the Web

Turn Private Browsing on or off on your iPhone - Apple Support

When you use Private Browsing, the details of your browsing aren't saved, and the websites you visit aren't shared with your other devices....

Incognito Mode May Not Work the Way You Think It Does

Incognito Mode May Not Work the Way You Think It Does. Every browser has a private mode—but the privacy it offers has a...

Browse in private - Computer - Google Chrome Help

You can switch between Incognito windows and regular Chrome windows. You'll only browse in private when you're using an Incognito window.

Private Browsing - Use Firefox without saving history

Firefox Private Browsing is great for viewing websites without saving things such as cookies, temp files, and a history of the pages you...

Style guide - A to Z - Guidance - GOV.UK

The Government Digital Service style guide covers style, spelling and grammar conventions for all content published on GOV.UK, arranged alphabetically.