question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update description text in Tips component in Rewards settings page to be factually correct regarding tipping buttons and possibilities on Android

See original GitHub issue

Description

Currently, the text in the Tips component in Rewards settings page (1.34.x) makes reference to Reddit, Github, Twitter, etc., as well as inline tipping buttons. These do not exist on Android, so the text should be changed for accuracy. (Android also doesn’t support Reddit nor Twitter at this time in general.)

Perhaps get this into 1.35.x hotfix, or 1.36.

Screenshot of current text for reference:

image

Ideally, the text we use should be universal across Android and Desktop. It’s better not to have to maintain two separate strings, one for desktop, one for Android.

Solution

Approved by Ryan McFadden (Feb 1, 2022):

See the one-time tips you've given to websites & creators. Learn more about tipping.

“Learn more” will link out to the following page: https://support.brave.com/hc/en-us/articles/360021123971-How-do-I-tip-websites-and-Content-Creators-in-Brave-Rewards-

This text will be the same across both desktop and Android UIs.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
Miyayescommented, Feb 11, 2022

@mkarolin second option, let’s go with: “Learn more about tipping”.

0reactions
Uni-versecommented, Feb 25, 2022

Verification completed using 1.36.105, Chromium 99.0.4844.45

PASSED on Samsung Galaxy S21 | Android ARM | Android 12

Acceptance Criteria:

Tips Card Details Learn more link
Screen Shot 2022-02-25 at 11 09 29 AM Screen Shot 2022-02-25 at 11 09 41 AM Screen Shot 2022-02-25 at 11 10 03 AM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Build Your First Android App - Tip Calculator Beginner Tutorial
Build an Android tip calculator app! After you enter a base amount and a tip percentage, the app will calculate the tip and...
Read more >
Inline tip button is shown in Reddit/Twitter/GH even ... - GitHub
Description Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings Steps to Reproduce Clean ...
Read more >
Make and propagate design updates - Android Developers
Let's make an update in the Figma component. Back in your Figma file: Select the Title text layer and in the Text section,...
Read more >
How do I tip websites and Content Creators in Brave Rewards?
In the Rewards panel, click on Send a Tip… In the tipping banner , the domain of the website you're supporting is displayed...
Read more >
10 quick Mastodon tips - axbom
I've now created a page with 10 instances to choose from, for people who haven't yet created an account and are feeling overwhelmed...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found