Update description text in Tips component in Rewards settings page to be factually correct regarding tipping buttons and possibilities on Android
See original GitHub issueDescription
Currently, the text in the Tips component in Rewards settings page (1.34.x) makes reference to Reddit, Github, Twitter, etc., as well as inline tipping buttons. These do not exist on Android, so the text should be changed for accuracy. (Android also doesn’t support Reddit nor Twitter at this time in general.)
Perhaps get this into 1.35.x hotfix, or 1.36.
Screenshot of current text for reference:
Ideally, the text we use should be universal across Android and Desktop. It’s better not to have to maintain two separate strings, one for desktop, one for Android.
Solution
Approved by Ryan McFadden (Feb 1, 2022):
See the one-time tips you've given to websites & creators. Learn more about tipping.
“Learn more” will link out to the following page: https://support.brave.com/hc/en-us/articles/360021123971-How-do-I-tip-websites-and-Content-Creators-in-Brave-Rewards-
This text will be the same across both desktop and Android UIs.
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (1 by maintainers)
Top GitHub Comments
@mkarolin second option, let’s go with: “Learn more about tipping”.
Verification completed using
1.36.105, Chromium 99.0.4844.45
PASSED on
Samsung Galaxy S21
|Android ARM
|Android 12
Acceptance Criteria:
See the one-time tips you've given to websites & creators. Learn more about tipping.