question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update search engine defaults for BR / AR

See original GitHub issue

Description

Update search engine defaults for:

  • Brazil (BR)
  • Argentina (AR)

Brave should be at the top of drop down list at brave://settings/search

Related: https://github.com/brave/brave-browser/issues/18331 and https://github.com/brave/brave-browser/issues/23814

Test plan

Region set to BR / AR

  1. Fresh profile
  2. Search onboarding should NOT be shown
  3. Default search engine SHOULD be Brave
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX)

  1. Fresh profile
  2. Search onboarding SHOULD be shown
  3. Default will NOT be Brave Search
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list - unless you’re in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Notes for test plan

https://github.com/brave/brave-browser/issues/23814#issuecomment-1195841652

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
kjozwiakcommented, Nov 4, 2022

This issue was closed incorrectly as the work on Android was not completed.

Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds

This particular PR can be verified on Android as well but the onboarding portion will be done via https://github.com/brave/brave-browser/issues/26318 as per https://github.com/brave/brave-browser/issues/26318#issuecomment-1299587680. @brave/qa-team when verifying the above, you can use the STR/Cases outlined via https://github.com/brave/brave-core/pull/15669#issuecomment-1299023358 & https://github.com/brave/brave-core/pull/15669#issuecomment-1299634053. However, rather than going through all the cases I did, each platform should:

  • pick either BR or AR (the new ones added)
  • pick one of the previous locales that have Brave as default (CA / DE / FR / GB / US / AT / ES / MX)
  • pick a locale that doesn’t have Brave as the default SE (example: Japan or Poland)
  • pick a locale that has Yandex set as the default SE
0reactions
Uni-versecommented, Nov 15, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using:

Brave	1.45.125 Chromium: 107.0.5304.110 (Official Build) (64-bit) 
Revision	2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS	Android 12;

BR (Brazil) Locale

Google/Brave
  • installed 1.45.123
  • ensured that Google was the default SE for Normal tabs
  • ensured that Brave was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Google is still the default SE for Normal tab
  • ensured that Google wasn’t replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527901695 screenshot-1668527989092
DDG/Startpage
  • installed 1.45.123
  • ensured that DDG was the default SE for Normal tabs
  • ensured that Startpage was the default SE for Private tabs
  • updated to 1.45.125 and ensured that DDG is still the default SE for Normal tab
  • ensured that DDG wasn’t replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527613401 screenshot-1668527702339
Qwant/Bing
  • installed 1.45.123
  • ensured that Qwant was the default SE for Normal tabs
  • ensured that Bing was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Qwant is still the default SE for Normal tab
  • ensured that Qwant wasn’t replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668527901695 screenshot-1668527989092

FR (France) Locale

Upgraded Profile (Brave/Brave)
  • installed 1.45.123
  • ensured that Brave was the default SE for Normal tabs
  • ensured that Brave was the default SE for Private tabs
  • updated to 1.45.125 and ensured that Brave is still the default SE for Normal & Private tabs
1.45.123 1.45.125
screenshot-1668528992545 screenshot-1668529060855
Upgraded Profile (DDG/Bing)
  • installed 1.45.123
  • updated default SE for Normal tabs to DDG
  • updated default SE for Private tabs to Bing
  • updated to 1.45.125 and ensured that DDG is still the default SE for Normal tab
  • ensured that DDG wasn’t replaced by Brave for Normal tabs
1.45.123 1.45.125
screenshot-1668529257963 screenshot-1668529331038

PL (Poland) Locale

Upgraded Profile (Google/Brave)
  • installed 1.45.123
  • ensured that Google was the default SE for Normal tabs
  • ensured that Google was the default SE for Private tabs
  • updated default SE for Private tabs to Brave
  • updated to 1.45.125 and ensured that Brave is still the default SE for Private tabs
1.45.123 1.45.125
screenshot-1668529796755 screenshot-1668529907553
Upgraded Profile (Bing/Bing)
  • installed 1.45.123
  • updated default SE for Normal tabs to Bing
  • updated default SE for Private tabs to Bing
  • updated to 1.45.125 and ensured that Bing is still the default SE for Normal tab
1.45.123 1.45.125
screenshot-1668530063318 screenshot-1668530104283

RU (Russia) Locale

Upgraded Profile (Yandex/Yandex)
  • installed 1.45.123
  • ensured default SE for Normal tabs to Yandex
  • ensured default SE for Private tabs to Yandex
  • updated to 1.45.125 and ensured that Yandex is still the default SE
1.45.123 1.45.125
screenshot-1668530370069
screenshot-1668530417842
Upgraded Profile (Google/Brave)
  • installed 1.45.123
  • updated default SE for Normal tabs to Google
  • updated default SE for Private tabs to Brave
  • updated to 1.45.125 and ensured that Google is still the default SE for normal and Brave is default SE for private tabs
1.45.123 1.45.125
screenshot-1668530656054 screenshot-1668530695499
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Change the Default Search Engine on All Browsers ...
In the window that pops up, look beneath Add-on Types, then click Search Providers. By default, Bing is the only provider listed. If...
Read more >
Make Google your default search engine - Google Search Help
In the "Advanced settings" section, click View Advanced settings. Under "Search in address bar with," click Change. ... Set as default. ... About...
Read more >
How to Change Your Default Search Engine in Chrome, Edge ...
Here's how to change your default search engine in Google Chrome: Open the Chrome browser. Click the three solid dots in the top...
Read more >
How to Change Your Browser's Default Search ... - MakeUseOf
Go to Settings > Privacy, search, and services. Scroll to the bottom of the page and click Address bar and search. Use the...
Read more >
NIS-Elements AR (Advanced Research) User's Guide (Ver.4.50)
Tool. A shortcut to NIS-Elements AR is created on the desktop too. ... Check the Enforce user to change his password at start-up...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found