Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix casing for context menu entries on MacOS

See original GitHub issue

Description

In https://github.com/brave/brave-browser/issues/25532 we had a discussion on the correct casing on macOS. The conclusion was that context menus should be Title Case.

We should update the Hide Brave Rewards icon text to be Hide Brave Rewards Icon Hide Brave Wallet icon text to be Hide Brave Wallet Icon

Anything else @stephendonner @sangwoo108 @aguscruiz

Issue Analytics

State:
Created a year ago
Comments:8

Top GitHub Comments

1reaction

sangwoo108commented, Oct 22, 2022

that works, though I’m not familiar with any best practices

https://developer.apple.com/design/human-interface-guidelines/components/system-experiences/the-menu-bar/

Prefer short, one-word menu titles. Various factors

This line is what I referred to.

re: labeling of UI elements for screenreaders.

Wow, this is a very good point. I’ve played with Voice Over on Mac, and find that it could be confusing. Voice over lets me know that I’m in the menu, but I can’t know for which this menu is. But in order to trigger a menu item for a button, the button should be focused and Voice Over let us know what button is focused now. So the flow is like

Focus button
Open menu
Navigate to the item

Maybe context menus for bookmarks could be an analog for this. They have random item title but doesn’t show it on the context menu. I think it could be okay because they’re literally “contextual” so users could be aware of what they’re interacting with.

Then I noticed that could be why Chromium folks put an extension name on the top of extension menu while it’s disabled. When using Voice Over and navigating items with keyboard, the name of an extension will be read out.