question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

update tip panel wording - follow up to 6228

See original GitHub issue

Description

With the changes in #6228 and #6288, and a new Monthly Contribution panel on brave://rewards, should the Tip panel text which mentions recurring monthly tips be updated?

Steps to Reproduce

  1. Clean profile 0.72.102
  2. Navigate to brave://rewards page
  3. Enable Rewards
  4. Scroll to Tips panel. Panel text mentions “You can also set up recurring monthly tips so you can support sites continuously.” and “Support your favorite sites with recurring monthly tips.”
  5. Refresh page.
  6. View Tips panel. Panel tex mentions “You can also set up recurring monthly tips so you can support sites continuously.”

Actual result:

Screen Shot 2019-10-15 at 3 29 21 PM Screen Shot 2019-10-15 at 3 28 16 PM

Expected result:

Unsure if text should be updated or removed.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.72.102 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @davidtemkin @NejcZdovc @rebron @kjozwiak

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
bradleyrichtercommented, Oct 17, 2019

@LaurenWags @ryanml @mandar-brave

Here is the new text:

image

image

Monthly Contributions Set up recurring monthly contributions so you can support sites continuously.

Your monthly contributions will be sent every 30 days.


Tips Tip content creators directly as you browse by using the Rewards Panel, or by using the inline tip button on various sites including Twitter, Reddit and GitHub.

Tip on the spot as you find gems.

If you like, let people know with a quick tweet.

0reactions
LaurenWagscommented, Nov 10, 2019

Per discussion in todays triage mtg, we are keeping these text changes in 0.71.x.

Verified Tips panel text with 0.71.x:

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

rewards-disabled-tip-text Screen Shot 2019-11-05 at 5 23 19 PM

Verified Monthly Contributions panel text with 0.72.x as it is not available in 0.71.x:

Brave 0.72.117 Chromium: 78.0.3904.87 (Official Build) dev (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
Screen Shot 2019-11-05 at 5 22 12 PM Screen Shot 2019-11-05 at 5 23 29 PM

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

image image

Verification passed on

Brave 0.72.119 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

image image

Verification passed on

Brave 0.71.113 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image image

Verification passed on

Brave 0.72.121 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

2022 Instruction 1040 - IRS
This is an early release draft of an IRS tax form, instructions, or publication, which the IRS is providing for your information.
Read more >
Owner's Manual & Assembly Instructions - pdf.lowes.com
Study and understand this owner's manual. Important information and helpful tips will make your construction easier and more enjoyable. Assembly Instructions: ...
Read more >
Glossary of Legislative Terms - Congress.gov
A panel (or subpanel) with members from the House or Senate (or both) tasked with conducting hearings, examining and developing legislation, ...
Read more >
5808 Manual - Honeywell Building Technologies
Smoke detectors must be installed in the same room as the control panel and in rooms used by the system for the connection...
Read more >
Announcements - UC Davis Office of Research
We need your feedback in order to make the IRB Administration website as useful to researchers as possible. Personnel updates. Mihaela Harris, the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found