Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Private window w/ Tor shows "new private window"

See original GitHub issue

Description

While testing https://github.com/brave/brave-core/pull/3686, I noticed a weird regression - cc: @yrliou who has done Tor work in Nightly (it may be due to that work? or Chromium 78? not sure)

Basically, in Dev channel for example (C77), when in a private window with Tor, you’re not given the option to create a regular private window

via the hamburger menu
via the menu (macOS)

On master/Nightly, when in a private window with Tor, you’re shown the option to open a new private window. If you do choose this, it opens a private window with Tor, NOT a regular private window.

hamburger menu
via the menu (macOS)

Steps to Reproduce

Launch master / Nightly
Open a new private window with Tor
Use hamburger menu, pick New Private Window

Actual result:

A new private window with Tor is shown

Expected result:

Menu option should not be there (see screenshot)

Reproduces how often:

100%

Brave version (brave://version info)

master/Nightly (0.72.x)

Version/Channel Information:

Can you reproduce this issue with the current release? n
Can you reproduce this issue with the beta channel? n
Can you reproduce this issue with the dev channel? n
Can you reproduce this issue with the nightly channel? y

Issue Analytics

State:
Created 4 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

yrlioucommented, Oct 29, 2019

@btlechowski Right, I think I’ll also fix the New window in the same PR.

0reactions

btlechowskicommented, Nov 14, 2019

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/3813

regular window

private window

private window with Tor

Verified passed with

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

Verified test plan from https://github.com/brave/brave-core/pull/3813
Verified able to open Normal, Private, Private with Tor windows from hamburger menu on each window type.
Verified able to open Normal, Private, Private with Tor windows from macOS file menu on each window type.
Encountered and logged #6926

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from https://github.com/brave/brave-core/pull/3813
Verified able to open Normal, Private, Private with Tor windows from the hamburger menu on each window type. Normal window: Private window: Private window with TOR: