Version management on MacOS for update
See original GitHub issueFor checking newer version from omaha server, sparkle uses CFBundleVersion
is used.
It’s last two part of full version.
(Ex, CFBundleVersion
is 72.95
whereas CFBundleShortVersionString
is 78.0.72.59
)
If we start our 1.0 with xx.1.0.1
, sparkle don’t update to our 1.0 because 0.1
is lower than previous one(ex, 72.59
).
We should test and handle this issue for our 1.0 era. cc @bsclifton @bbondy @mbacchi @mihaiplesa
What is our version string policy with 1.0?
As you can see with below capture, we set two version strings when update dmg to Omaha server and
Version
string maybe used for checking newer version from Sparkle.
If we want to start with 1.0.0
, IMO, managing Version
separately would be one possible option by just incrementing from our latest version. WDYT?
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:7 (6 by maintainers)
Top GitHub Comments
@LaurenWags the test plan for both Mac and Windows is described in issue https://github.com/brave/devops/issues/2042. Please let myself, @bsclifton or someone in the releng team when you want to test and we can set the dev omaha server up with the correct versions to perform tests.
Verified PASSED on
macOS x64 Catalina 10.15.1
by @kjozwiak Verified PASSED onmacOS x64 High Sierra 10.13.6
by @LaurenWags macOS testing notes can be found here: https://github.com/brave/devops/issues/2042#issuecomment-552611208