`window.phantom` being defined breaks several websites
See original GitHub issueDescription
Trying to login with valid (or invalid) credentials triggers a fatal error on some websites, preventing login.
Works fine in Brave version 1.42
(before 1.42.81), 1.41
and in Chrome. Also works fine in a private window
Steps to Reproduce
- Visit https://accountaccess.edwardjones.com/ca-logon/logon.action
- Put in username
braveuser
- Put in password
AbbbAAbbcdD11
- Click Log In button
Actual result:
Error is shown Due to a system problem, we are unable to log you in at this time. Please try again later. If the problem continues, contact Online Client Support at 800-441-5203.
Expected result:
Should show an error The system did not recognize the user ID and password you entered.
Reproduces how often:
100%
Brave version (brave://version info)
1.43.42 or newer (Nightly) 1.42.81 or newer (Beta)
Version/Channel Information:
- Can you reproduce this issue with the current release? no
- Can you reproduce this issue with the beta channel? yes
- Can you reproduce this issue with the nightly channel? yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? no
- Does the issue resolve itself when disabling Brave Rewards? no
- Is the issue reproducible on the latest version of Chrome? no
Miscellaneous Information:
Problem did not exist in 1.43.41
. Problem started occurring with 1.43.42
.
https://github.com/brave/brave-core/commits/19d8fe92f1887055072d62f1e7e6546053964515
I was able to reproduce from source code (git checkout -b bsc-troubleshooting v1.43.42
) and commenting out this line fixed the issue for me (I don’t know why):
https://github.com/brave/brave-core/blob/f54f6be60d18d8e9496c72c3a3afc974cbc784d4/components/brave_wallet/renderer/js_solana_provider.cc#L159-L161
Issue Analytics
- State:
- Created a year ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
Just posted that this wallet issue fixed the bank website issue. I am wondering how many other Brave Beta users are having this problem. Thanks @bsclifton for the heads up changing the wallets to NONE fixed this issue for me. I do not use Brave for crypto or BAT.
This can also happen if you install and setup Phantom extension using Chrome. The website will give the exactly same error because it sees
window.phantom
disregarding who inserted it.