Lightrun
question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add rotating hash to payload - followup to 23055

See original GitHub issue

Description

Steps to Reproduce

  1. Launch browser
  2. Join rewards
  3. Navigate to brave://rewards-internals

Actual result:

Device Id: Unknown is shown on Ad Diagnostics

Expected result:

Device Id: ... should be shown on Ad Diagnostics, where … is the device id (which never leaves the local machine)

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
LaurenWagscommented, Aug 16, 2022
0reactions
kjozwiakcommented, Aug 24, 2022

Went through the verification’s using the following build(s):

Brave | 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}

Verified steps from https://bravesoftware.slack.com/archives/GAA4017R7/p1660671903953109?thread_ts=1660148977.287319&cid=GAA4017R7.

Win 11 x64 (Physical machine) - PASSED

Before restart: Device Id: 9babaa3c0d282cf5a6e3594c7065d27b682568e52e849602bcd76ee128a71c83

After restart: Device Id: 9babaa3c0d282cf5a6e3594c7065d27b682568e52e849602bcd76ee128a71c83

Win 10 x64 VM (Hyper-V) - PASSED

Before restart: Device Id: 0e611d0e210479ca9ae3812ed5df920fe62c6e3e611c96aec9fc9686da5a185a

After restart: Device Id: 0e611d0e210479ca9ae3812ed5df920fe62c6e3e611c96aec9fc9686da5a185a

Win 10 x86 VM (Hyper-V) - FAILED

Before restart: Device Id: Unknown

After restart: Device Id: Unknown

Example Example
image image
PopOS 22.04 x64 VM (VM Workstation Pro) - PASSED

Before restart: Device Id: 733c959a43224e3ded00952caa391a71c9e31c5f70328a69c01ce3d4e7a5368e

After restart: Device Id: 733c959a43224e3ded00952caa391a71c9e31c5f70328a69c01ce3d4e7a5368e

macOS x64 Monterey 12.5.1 (Physical machine) - PASSED

Before restart: Device Id: 7d6152ede1e4ea03d82cbe33fd5687f9c60391dec83d9ba62df529b8041acd76

After restart: Device Id: 7d6152ede1e4ea03d82cbe33fd5687f9c60391dec83d9ba62df529b8041acd76

macOS x64 10.13.6 High Sierra VM (Parallels Desktop 18) - PASSED

Before restart: Device Id: 1304864c7cc3af5c5f78f52a4b21ce9e58b7475a1a29b99f59fad8ddbbbd6726

After restart: Device Id: 1304864c7cc3af5c5f78f52a4b21ce9e58b7475a1a29b99f59fad8ddbbbd6726

Win 8.1 x64 VM (Parallels Desktop 18) - PASSED

Before restart: Device Id: a58a537264e304f3d67658c20b7bb36d2d53b001896f70e217077ca896ebbbbb

After restart: Device Id: a58a537264e304f3d67658c20b7bb36d2d53b001896f70e217077ca896ebbbbb

Win 8.1 x86 VM (Parallels Desktop 18) - PASSED

Before restart: Device Id: 1aa883222a315585cc33325b56c5c7db808e44fa6550b369a4df13b8fd4e1b95

After restart: Device Id: 1aa883222a315585cc33325b56c5c7db808e44fa6550b369a4df13b8fd4e1b95

Win 10 x64 VM (Parallels Desktop 18) - PASSED

Before restart: Device Id: a915a1e7d42a56bcc5a8db69c0d974df920304f1dac072b5a03bed5d0d01c985

After restart: Device Id: a915a1e7d42a56bcc5a8db69c0d974df920304f1dac072b5a03bed5d0d01c985

Win 10 x86 VM (Parallels Desktop 18) - PASSED

Before restart: Device Id: d713c9f66be79c9bc0fd900a6142778e0b6980681bb7e6d641570f8f5be8a0a2

After restart: Device Id: d713c9f66be79c9bc0fd900a6142778e0b6980681bb7e6d641570f8f5be8a0a2

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found
Previous page

Unable to import saved passwords from Edge (Chromium, macOS, Linux)

Next page

`window.phantom` being defined breaks several websites