Add ability to turn off badge on icon

General information

• Operating system + version: Ubuntu 18.10
• Browser + version: Firefox Nightly 68.0a1 (2019-04-08) (64-bit)
• Information about the host app:
  • How did you install it? pre-built binary
  • If installed an official release, put a version Browserpass host app version: 3.0.6
• Information about the browser extension:
  • How did you install it? AMO
  • Browserpass extension version as reported by your browser: 3.0.9

Exact steps to reproduce the problem

1. Install the extension

2. Open a domain with saved passwords

What should happen?

The ability to turn off the icon badge should exist.

The first thing I do is turn this off on any extension.

What happened instead?

It doesn’t or is buried somewhere hard to find.

[mcnesium]

Thumbs up everyone 😃

Though this is solved already, I would like to add an argument for this option: as a friend of explaining problems through providing a screenshot, I often do so with the entire browser window (e.g. because the current URL is important, or whatever). In this case I would either have to temporarily remove the icon first, or otherwise expose the number of accounts I have on this site to the public. This sounds like being a theoretical problem and in 99% it propably is, but there could be this one incident where an information like this leads to the world imploding (see Butterfly effect). I am sure you wouldn’t want to be guilty of this, just to keep the code simple, right? 😉

Thank you everyone who’s involved in this!

[jplitza]

@maximbaz Sure thing! #194