Electron v8 deprecation warning

Describe the bug This is not so much a bug but for versions 8 and above of Electron. I am using v8 and I get:

DeprecationWarning: Passing functions, DOM objects and other non-cloneable JavaScript objects to IPC methods is deprecated and will throw an exception beginning with Electron 9

To Reproduce Use v8 and above of Electron.

Expected behavior I’m assuming that electron-tabs sends the webview event to main in the background. I can see the event using ‘will-attach-webview’ in main. I was trying to add src from there but still the same warning.

Please complete the following information

• OS: Windows 10
• electron-tabs version: 0.12.1
• Electron version: 8

** Additionally ** Is there a reason that only ‘file’ protocol maybe used as opposed to a custom scheme protocol ?

[brrd]

Demo runs fine.

So your issue is definitely not related to electron-tabs. I’m closing this thread.

Just a note, not shown here - to load my local html file (not for the webview) along with its assets I have a registerFileProtocol in main. However for the tab and webview using the custom scheme does not work. Like I can’t say in the tab configuration src: app://myfile.html, even though the scheme ‘app’ serves files. I had to use src: file://myfile.html.

electron-tab is using webview src attribute under the hood without any modification. Please ask your question in Electron forums since we do not deal with registerFileProtocol here.

// I set src and preload now in main, when will-attach-webview is called

This is not the recommended way to use electron-tabs. I can’t guarantee it will work as expected if you are using it this way.

webview.send(“open:tab”, [webview, tab]);

Not 100% sure, but your IPC warning is probably caused by this instruction, since webview.send() uses IPC and webview and tab contain DOM elements.

[stuartambient]

Thanks for the help on this one. Apologies as my webview.send() hadn’t crossed my mind earlier.