Tab Navigation broken?

Describe the bug When I click on any tab. it gets active and I see it’s webview. but when I click on another tab (which was clicked before), nothing changes.

So, let’s say I open app, I make a tab and load Google. I open another tab and load Amazon. Both of them will get background of white color indicating both are active. when I click on the Google tab, nothing happens. I stay on Amazon. when I close amazon, I’am able to load Google tab.

To Reproduce 1- Create a tab. 2- Create another tab. 3- connot load 1st tab anymore.

Expected behavior I should be able to load any tab when I click on it.

Please complete the following information

• OS: Windows 10
• electron-tabs version 0.15.0
• Electron version 9.0.0

Code If your issue involves code, please consider creating a sample in a dedicated repository.

Screenshots Additional information Thanks.

[brrd]

I think there is something wrong in https://github.com/PocketInc/Pocket-Browser/blob/09547698ab9f483052da602409a015fc9be1fc16/tabs.js

function addTab() {
  const TabGroup = require("electron-tabs");
  let tabGroup = new TabGroup();
  let tab = tabGroup.addTab({
    src: homePage,
    title: "New Tab",
  });

  log.info("Opening new tab.");
}

Each time you use addTab() this creates a new tabGroup with a single tab.

Try this instead:

const TabGroup = require("electron-tabs");
const tabGroup = new TabGroup();

function addTab() {
  let tab = tabGroup.addTab({
    src: homePage,
    title: "New Tab",
  });

  log.info("Opening new tab.");
}

And make sure this code is run once document is ready.

I’m closing this issue since it is not caused by electron-tabs.

[AhmadHrb]

Thank you. I can’t imagine how I fell in such thing XD Thanks again, and sorry for the trouble.