question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken with React 16.9?

See original GitHub issue

Hi, I’m trying to refactor react-select v1.x to work with React 16.9, and the test suite for that version are using unexpected-react.

A few of the tests are failing, with output like:

UnexpectedError: 
expected null to contain
<div className="Select-multi-value-wrapper">
  <div><span className="Select-value-label">Yes</span></div>
  <div><span className="Select-value-label">No</span></div>
</div>

After digging into one of the failing tests with the node debugger, I traced the problem to the call to this function returning null: return RenderHook.findComponent(component);

So it seems like react-render-hook might not be working with React 16.9 ? If I remember correctly, this latest version of React shipped with a new dev tools API…

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
jharris4commented, Sep 10, 2019

Thanks for the response! There were quite a few tests in react-select, and it’s actually an old unmaintained fork, so I’d say not worth your time unless there’s a trivial way to fix the react-render-hook package to get this package working again…

0reactions
jharris4commented, Dec 4, 2019

Awesome, thanks for looking into this!

I’ll try it out the next time I tinker with the related tests.

Read more comments on GitHub >

github_iconTop Results From Across the Web

React v16.9.0 and the Roadmap Update
React 16.9 does not contain breaking changes, and the old names continue to work in this release. But you will now see a...
Read more >
Bug - Upgrading `react-dom` from 16.8.6 to 16.9.0 breaks tests ...
When upgrading to react-dom 16.9.0, I have several jest tests break. The first failure is pasted below. There are other failures to do...
Read more >
Create-react-app is installed with internal broken ...
I managed to solve that problem by performing the following steps: 1.- Delete the package-lock.json file in addition to node_modules.
Read more >
New Features in React 16.9.0 - Telerik
This is a quick overview of all the new features of the latest version of React JS.
Read more >
react-scripts - npm
Configuration and scripts for Create React App.. Latest version: 5.0.1, last published: 9 months ago. Start using react-scripts in your ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found