Cleanup

Just a tracking task from review.

Important:

• Conform to Go Style Guide 😃 comments, splitting up of files, we should have a Golang eng do a pass with Timo
• DOCS - we should have extensive examples, justification about why this is better than alternatives
• Have someone who is not Timo who is also an expert in JS do a deep dive, probably Paul, optimally get some external feedback
• Update LICENSE to to 2021-2022 ✅

Random comments:

• Evaluate moving private/protoplugin to new repository protoplugin-es? Probably not to start but worth a conversation.
• Move cmd/internal to internal.
• See comments on https://github.com/bufbuild/protobuf-es/pull/35, tldr get rid of options if possible ✅
• Update go.mod to at least 1.17 (not really needed but) ✅
• Rename GOOG to GOOGLE_ in the Makfile 😃 ✅

[paul-sachs]

Interesting. The actual use case I ran into this on was updating the state of a given user:

setSomeState((prev) => new User({
  ...prev,
  deactivated: true,
}));

After this operation, the nested createTime field was missing those properties and in fact failed instanceof checks as well. I assume the root cause is similar since the spread operator would have set the Timestamp instance as it was, similar to new Timestamp().

My case above was obviously just a toy case to reproduce the more complicated version.

[timostamm]

It’s PlainMessage<T>. Thanks for bringing this up, it should have more visible documentation.