Infinite Loading FlexTable: Dataset Of One Causes State Problem

Hey there!

I think I found a bug, or… I am just missing something obvious.

Thanks for your work on RV!

Issue Loading a single item list into an Infinite Loading FlexTable prevents any future changes, even after a clearing of state.

My guess would be how the caching is being done, but I wasn’t able to make any headway on that.

Steps

• Take the Gist below and replace InfiniteLoader.example.js in the RV source with it.
• Start server, go to InfiniteLoader, etc.
• Click ‘Only Two’.
  • This should give you only two results.
• Click ‘Multi-Page’.
  • This should give you a standard Infinite list.
• Click ‘Clear Data’.
  • This should… clear the data.
• Try any order combination of those 3 buttons.
  • This should not break anything…
• Click ‘Only One’.
  • This should give you only one result.
• Click ‘Only Two’ or ‘Multi-Page’.
  • This should hang at loading.
• Click ‘Clear Data’.
  • This should clear the table, but no further button clicks will load results.

tl;dr - Once a result of a single row is loaded you can’t un-stick it.

// Line 39: If you change this...
const rowCount = hasNextPage ? list.size + 1 : list.size;
// Into this...
const rowCount = hasNextPage ? list.size + 2 : list.size;
// But you are left with an extra loading row showing.

Example Gist

❤️

[SpencerCarstens]

I’d need to know more info about your particular situation I guess. I don’t know why using componentDidUpdate to look for a changed prop (or props) wouldn’t work. 😄

Well, it does work, but not ideally. 😛 _loadMoreRows gets called twice, and therefore does two API calls ( your gist does this as well ). Granted, this can be worked around by making a check for it being an initial call or something like that. I was just hoping to have to avoid that kind of thing. 😄

[SpencerCarstens]

I was thinking, how would you feel about a public function on InfiniteLoader to clear the memoized data? The reason I ask is that I’ve ran into another snag, but this time with a result set of zero. While I can get around it by forcing this._loadMoreRows using componentDidUpdate, managing when ( much more importantly when not! ) to do that is hairy ( in my situation at least ). Being able to clear the memoized cache manually when I call my this._clearData() function would be ideal ( for me at least ).