Performance issues with Grid.js and scrollTop check

Hi thank you for this library, it’s amazing.

I want to ask what the need of this check?

I have a component which in some situations animate scrollTop property of VirtualScroll component, and even in production I got 30-50ms per frame (I have a lot of lines on the screen).

It’s because check causes reflow. Just removing this line highly (4+ x times) increases performance of my component without lose of any functionality. I got stable 8ms per frame on scroll animation.

I’ve read your comments about autoHeight coupling, and what I want is another boolean property and I know that it’s bad idea.

May be you have any ideas about how to remove this check? Or move all that checks outside control?

[bvaughn]

Don’t you think that onScroll should not be called if scrollTop was changed not by the scroll event?

Unfortunately that used to be how it worked but it caused problems for certain use-cases of scrollToRow / scrollToColumn (see issue #399).

In your case, you could ignore onScroll events with scrollTop values that match your component’s state (or wherever you’re storing the scrollTop prop)?

[bvaughn]

That’s so great to hear!! 👏 😀 Thanks @istarkov!