Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[CTA, cardlink] Missing card link option for CTA

See original GitHub issue

Looks like over time our CTA cards have misaligned. Misaligned between libraries, misaligned between specs, styles and intent.

Here is the problem:

In short, react and web components do not line up. React’s CTA depends on Card link while Web components depends on Card. So changing card link in CSS impacts one differently than the other and impacts unwanted changes to other components. Also, Card link isn’t to specs visually and functionally. Thirdly we missed a step which might have caused some of these problems, and don’t account for both card and card link being used as a CTA.

Here is a small visual to see the difference. The red is where it breaks down and the problems line up.


Here is my proposal:

  1. Card link needs to go be refactor to align with the design specs and functional specs.
  2. CTA needs a new style called card link this requires a functional spec update as well.
  3. Update and distinguish components with correct CTA style card link or card. (e.g. content blocks get card link, card group gets card)
  4. There are a couple odd situations like content block with media, and logo grid that use card link directly. Those should be leveraging the content block CTA as specced out.
a quick visual to help see the new dependency tree I’m proposing.


HC Developer: Putra Bonaccorsi HC Jira Ticket: DDS Consulting Dev: Ari

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:13 (6 by maintainers)

github_iconTop GitHub Comments

shixiedesigncommented, Aug 24, 2021

Thank you @proeung 🙏 👍 !!

RobertaJHahncommented, Aug 26, 2021

Fixing this issue may also fix issue #6985. Once fixed, let Kenny know so that he can check on the status of that bug. @proeung @annawen1 @kennylam

Read more comments on GitHub >

github_iconTop Results From Across the Web

CTA Press Release - Replacement Chicago Cards to be Sent ...
Registered Chicago Card customers will not be required to contact the CTA to get a new Chicago Card to replace the one expiring....
Read more >
IDHS: Report or Replace Lost/Damaged Link Card - Illinois
Report a lost Link Card and order a replacement. There are two ways. Go to the Illinois Link Card Website OR; Call the...
Read more >
Carousel Link Ad FAQs - Amazon AWS
A: Same as a carousel ad with images. If a CTA is chosen, each card will have to have the. CTA. Q: What...
Read more >
How to Change the DHS Card "CTA" - Pushpay
At the bottom, you will see the field labeled CTA. Select between the different CTA options as displayed below.
Read more >
Insert One: Credit Card Tokenization - CoreCommerce
CardConnect offers a patented “card on file” feature, which allows customers to store a credit card for future use in your online stores....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found