Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

🩺 for Healthchecks

See original GitHub issue

Hello @carloscuesta 😎!

Emoji: 🩺
Code: :stethoscope:
Description: When healthchecks have been added or updated.

I already submitted PR #667 for this.

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:6 (4 by maintainers)

Top GitHub Comments

7reactions

hf-kkleincommented, Dec 30, 2020

Thanks for your feedback!

But I’m a little bit worried about the specificity of it

I agree it’s a very backendish thing.

and I don’t see this being used more than once 🤔

It’s not uncommon to have multiple health checks or adding more checks over time. Usually there is one common endpoint, which is only created once; that’s right. But there might actually be more than one check that is run when calling the health check endpoint. Think of, for example:

check that the database is up and running
check that the redis is up and running
check that credentials for various third party services (external API, mail server…) are correct
check that environment variable required for feature xyz is set.

So I wouldn’t say it’s a “once a in project lifetime” commit emoji as basically a lot of features could come with their own health check that needs to be written and registered. For these commit emoji would imho be useful.

4reactions

vhoyercommented, Dec 30, 2020

I’m personally not a huge fan of commits that you only use once in the project, and I don’t see this being used more than once 🤔