question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change emoji for code review changes

See original GitHub issue

Hello @carloscuesta 😎!

I already opened a PR (jumped the gun a little there), but it seems like it might be worth changing the code review suggestion emoji to something other than the ok hand as that has been co-opted by white nationalists.

  • Emoji: 👀 :
  • Code: :eyes:
  • Description: Eyes imply that someone has looked at the code to review it so it seems like an appropriate emoji.

There are well documented issues with the ok hand and changing that emoji could eliminate a potential trigger for some and make this project more inclusive.

Related with https://github.com/carloscuesta/gitmoji/pull/461

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
vhoyercommented, Jun 18, 2020

You know, we are discussing the removal of this emoji on #348, maybe we can post-pone this PR until we are set on whether we are removing it or not 🤔

1reaction
johannchopincommented, Jun 17, 2020

Here’s a theme I’m always wondering about. Why make things worse than they are? Certainly some people have used this gesture as a racist sign but for all that will have to completely change the meaning of it? If tomorrow the white nationalists shake hands as a sign of supremacy will we all stop shaking hands?

I am of the opinion that ancestral symbols should not be tarnished by a few people.

Lets just keep 👌 since it’s an ok hand

Read more comments on GitHub >

github_iconTop Results From Across the Web

erikthedeveloper/code-review-emoji-guide - GitHub
📘 Code Review Emoji Guide. A simple emoji legend to help convey intention and added meaning in code review comments. A picture is...
Read more >
My Code Review Emoji Guide - brendanforster.com
My Code Review Emoji Guide · Feedback can fall into a number of different categories, and not everything should be addressed immediately (or...
Read more >
How We Do Code Review - App Center Blog
The Emoji Code helps us separate well-meant suggestions, simple questions, and must-have requests that require code changes.
Read more >
How to Use Actionable Emojis in Your Pull Request Reviews
Consider prefacing a review comment with different emoji to classify the ... Pair these with a “Request Changes” review to emphasize that ...
Read more >
gitmoji | An emoji guide for your commit messages
Aims to be a standarization cheatshee /t for using emojis on GitHub's commit messages. ... Update code due to external API changes.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found