Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

document the onChangeComplete delay and make it configurable

See original GitHub issue

I couldn’t find any explanation in the documentation as to what onChangeComplete actually does. The code reveals that it is a hardcoded debounce with 100ms.

I suggest:

  1. Document the behavior
  2. Make the 100ms configurable

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:4
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

oliverhauslercommented, Sep 23, 2019

There is an event missing. Most controls have onScroll, onChange, onChangeComplete. Here we have only two, and debouncing won’t solve all issues. As we need to keep backward compatibility, I would suggest adding another event onColorSelected when the mouse button is released.

onChangeComplete is definitely named wrong, as nothing, ever, is complete while the user is still holding the mouse button down.

texelscommented, Dec 14, 2018

For sliders and color grids, It would be great if the onChangeComplete was only fired when the user released the mouse, not when they stopped moving the mouse. For an undo system, i want to undo when the user releases the mouse, not when they stop dragging

Read more comments on GitHub >

github_iconTop Results From Across the Web

Issues · casesandberg/react-color · GitHub
document the onChangeComplete delay and make it configurable enhancement help ... How can I get unique data-id in event so that respective state...
Read more >
How to troubleshoot poor performance on M… - Apple Community
After it runs post the log file here. It will contain no personal information. Allowing full drive access will improve the quality of...
Read more >
How to create my own onChangeComplete function for input ...
I can use ready-made onChangeComplete function from react-color. But I wonder how can I create that onChangeComplete by using input type color ...
Read more >
react-color SketchPicker JavaScript Examples
Source Project: react-drag Author: daisybaicai File: picker.js License: ... Body> <SketchPicker width="95%" color={this.state.color} onChangeComplete={this.
Read more >
Diff - 9ba2a188919e6e5bf8c042b26527fc090de677ef^2 ...
ComponentName configure; field public int icon; + field public int ... {@link android.appwidget as described in the AppWidget package documentation}.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found