#FFF circle color picker selected state on white background

If you use a CirclePicker color of #fff (white) and put it on a white background, the box shadow color is white and the ‘selected’ circle that appears is also… white. This leaves you with basically an invisible color picker.

I would propose that if one of the CirclePicker colors is #fff then make the box shadow color #000 by default and change the ‘selected’ circle that appears to additionally include a #000 colored border on it.

I know I can override this with CSS but I feel this shouldn’t need to be overridden.

I would make a ‘pull request’ to offer these changes for you but I don’t quite understand how pull requests work. I don’t get why it’s asking me to compare branches when all I wish to do is submit a single file.

Edit With that said, how exactly do I override the default CSS? I attempted to copy react-color/lib/components/circle/circle.js and react-color/lib/components/circle/CircleSwatch but I just get an error any time I click the color…?

[casesandberg]

Hmm, maybe we need to do something custom for the white swatch. Maybe we should add a slight border to it or something?

[jeffsheets]

@bruno-silva5 that’s nice with the CSS title selector! Thanks, I’m going to modify ours to be pure CSS too!