Carry annotations from interface into generated implementation

Has this been considered? The following is an example use case:

class Foo @AssistedInject constructor(@Assisted val assisted: Bar) {
  @Reusable
  @AssistedInject.Factory 
  interface Factory {
    fun create(assisted: Bar): Foo
  }
}

to generate a factory implementation annotated with @Reusable:

@Reusable // This line is new
public final class Foo_AssistedFactory implements Foo.Factory {
  @Inject
  public Foo_AssistedFactory() {
  }

  @Override
  public Foo create(Bar assisted) {
    return new Foo(assisted);
  }
}

I understand it’s probably a bit questionable since something like this would also leave the interface annotated which may not be desirable, but considering interfaces have no implementation I see no major issue with it, and there may also be other mechanisms to achieve the same goal and don’t have this issue. Thoughts?

[JakeWharton]

Ok! It’s not that urgent. There’s three whole days left this week, and Monday would be fine, too.

[stoyicker]

I have a patch half-way through for annotations in dagger.* packages. Just need to add/update some tests but I’m afk right now, I’ll have it ready in a few hours

On Tue, 10 Nov 2020, 20:50 Jake Wharton, [e-mail] wrote:

I would like to do a release this week. Let me know how you are progressing and if you want me to take over. We can start with just special casing that annotation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/square/AssistedInject/issues/158#issuecomment-724928467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHCRYXQH2WIL6VFP7CLI3SPGKQZANCNFSM4TQOISOQ .