Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Migrate config to globalvariables

See original GitHub issue

There are currently only a few values in config. I propose we remove “config” completely and migrate these values to globalvaribles.

This removes two locations (config and globalvariables) that developers have to modify when starting SmokeDetector and allows us to remove a ConfigParser import that is only used at start up.

Issue Analytics

State:
Created 7 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

3reactions

ArtOfCode-commented, Jul 8, 2016

We should let as many things be empty as possible. The fewer things you have to set before running the bot, the easier it is to get started.

0reactions

AWegnerGitHubcommented, Jul 8, 2016

I am happy with environment variables and default fullbacks for both location and the chat prefix strings.

The MSkey should allow for nonexistence (since I don’t run MS locally when testing smokey). On Jul 8, 2016 12:57 PM, “Undo1” notifications@github.com wrote:

I don’t see any reason that they shouldn’t be environment variables either. It should probably allow start without metasmoke information, but perhaps require the location (Running on [location]) to be present, either as an environment variable or as a command line option.

Your other suggestion of being able to change the [SmokeDetector] prefix and repo link would also fit in well - perhaps try to read from environment variables / command line options, then fall back on defaults?

On Fri, Jul 8, 2016, 11:52 AM A Wegner notifications@github.com wrote:

It seems we’ve decided what to do with the MS Key - put it in an environment variable.

What is the opinion on the other values in config?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/Charcoal-SE/SmokeDetector/issues/170#issuecomment-231427317 , or mute the thread < https://github.com/notifications/unsubscribe/AE7FZuBhvPUDazNEE3-gz2IzEXAZL8S_ks5qTo5pgaJpZM4JHcM5

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Charcoal-SE/SmokeDetector/issues/170#issuecomment-231428653, or mute the thread https://github.com/notifications/unsubscribe/AGKb5wtt31H4Xy8nkzdRzlDbC8EqApc2ks5qTo-SgaJpZM4JHcM5 .

Top Results From Across the Web

Avoiding Global Variables For Configuration File Reading in C

First of all, if the values are read once and never changed after that, then storing them as global variables is not a...

Transferring Configuration Files to a New Version of TestStand

How do I do this? TestStand saves all of its configuration data, including Station Global Variables, Users and Templates, as .ini files in...

Import global variable,connection, adapter from other server ...

I'm setup git with intergration server, problem here is it take too much time to setup local IS Now in my server have...

Manipulate Global Variables

Double-click on the global variable in the Configuration Components Pane. (Right-clicking then clicking Properties also works) · Enter the new value for your ......

How do I share global variables across modules - python

The best way to share global variables across modules across a single program is to create a config module. Just import the config...