Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The project lacks some structure. For example, is a mix of rules, checking functionality, and finally, a method to check a post and generate a “why”.

I’ve created a branch to see if there’s something we can do to make the project more maintainable, and re-organized a few files. The change moves 3 blacklist text files to a “blacklists” folder, and moves the “rules” and the “checking” functions to separate files.

Now I’m sure there’s more that can be done, and I wouldn’t be surprised if that change, as is, breaks SD (Seeing as I have 0 experience with Python), but I’m curious to see if the team is open to changes in the project’s structure, like this.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:5
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

rschriekencommented, Mar 1, 2017

I’m forced to ask this: does the public interface of the code you touch have a working unit test with reasonable coverage? If not, fix that first …

dorukayhancommented, Feb 21, 2017

large refactors have a nasty habit of badly breaking Smokey

What if we break down these large refactors into whole bunches of little organizational tweaks and then apply those tweaks incrementally?

Read more comments on GitHub >

github_iconTop Results From Across the Web

What is Refactoring (Code Refactoring)? - TechTarget
Refactoring generates the most return on investment when it can address a significant issue without taking too much time and effort.
Read more >
Code refactoring - Wikipedia
In computer programming and software design, code refactoring is the process of restructuring existing computer code—changing the factoring—without changing ...
Read more >
Refactoring is a Development Technique, Not a Project
“Refactoring is a controlled technique for improving the design of an existing code base. Its essence is applying a series of small behavior-preserving ......
Read more >
Code Refactoring Best Practices: When (and When Not) to Do It
Earlier we stressed that refactoring should never affect the performance of an application and that it should only serve as a clean-up effort....
Read more >
The Power of Code Refactoring: How to Measure ... - Stepsize
Many engineering teams struggle to measure the effectiveness of their refactoring efforts. Let's look at the 5 metrics that will help you ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found