Refactor effort?

The project lacks some structure. For example, findspam.py is a mix of rules, checking functionality, and finally, a method to check a post and generate a “why”.

I’ve created a branch to see if there’s something we can do to make the project more maintainable, and re-organized a few files. The change moves 3 blacklist text files to a “blacklists” folder, and moves the “rules” and the “checking” functions to separate files.

Now I’m sure there’s more that can be done, and I wouldn’t be surprised if that change, as is, breaks SD (Seeing as I have 0 experience with Python), but I’m curious to see if the team is open to changes in the project’s structure, like this.

[rschrieken]

I’m forced to ask this: does the public interface of the code you touch have a working unit test with reasonable coverage? If not, fix that first …

[dorukayhan]

large refactors have a nasty habit of badly breaking Smokey

What if we break down these large refactors into whole bunches of little organizational tweaks and then apply those tweaks incrementally?