Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Smokey tests fail to run on Windows

See original GitHub issue

Smokey Detector includes a Windows incompatible library: sh. This is clearly noticed when running tests locally.

sh will not support Windows

pbs will no longer be supported

ImportError while importing test module 'H:\Development\SmokeDetector\test\'.
Hint: make sure your test modules/packages have valid Python names.
test\ in <module>
	from chatcommunicate import * in <module>
	import chatcommands in <module>
	from gitmanager import GitManager in <module>
	from sh import git
h:\Anaconda\lib\site-packages\ in <module>
	support." % __version__)
E   ImportError: sh 1.12.9 is currently only supported on linux and osx. please install pbs 0.110 ( for windows support.

Is there an alternative we can utilize that will allow developers in both environments to work without the above error?

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

tewardcommented, Feb 22, 2017

So, I’ve looked into this a little. It’ll be a hackish mess where we have to replace the sh library with, essentially, a single git command and have to specify the commands we want to execute as a string passed to a subprocess call. This is… not very pretty actually, and very hard to actually get working the same way that sh’s git functionality operates.

Even with such hackish approach, it’s got some headaches and evils with it, such as we then have to strip shell colors, etc. and we have to reapproach how we handle exit codes and git calls in many places. For now, I’m going to mark this as ‘status: declined’, but we can revisit this in the future when we’re all a bit less busy. Between me, ArtOfCode, and Undo, we are all trying to figure when Smokey would be run in Production environments, and we can’t think of any - we all currently run in Linux environments, either on our own systems or EC2 instances, or VPSes, or other such environments which support the sh module.

tewardcommented, Feb 23, 2017

@AWegnerGitHub indicated in Charcoal HQ they’d test the docker instance yesterday. I did point them at my “Don’t Support Git Functions” warning approach for Windows runs - untested, but ultimately doesn’t require additional containerizaiton, etc. on the host system. And eliminates the git function issues that @AWegnerGitHub was complaining about.

This approach is in, also in PR #544, and one or both approaches may be useful enough for them.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Smoke test fails in Windows · Issue #8827 - GitHub
The highlighted smoke test unfortunately fails when running in Windows CI. I tried to reproduce it with my Parallels VM where it was...
Read more >
How to stop build if smoke tests fail? - MSDN - Microsoft
Hi,. You can use SetBuildProperties and set CompilationStatus="Failed" to do this. Here are some links which might help you. http://social.msdn.
Read more >
Smoke testing (software) - Wikipedia
In computer programming and software testing, smoke testing is preliminary testing to reveal simple failures severe enough to, for example, reject a ......
Read more >
What is Smoke Testing? - Guru99
Smoke tests are a minimal set of tests run on each build. ... Any failure indicates a need to handle the system back...
Read more >
HP PCs - Testing for hardware failures in Windows 10
1. In Windows, search for and open the HP PC Hardware Diagnostics for Windows app. 2. On the main menu, click System Tests....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found