`shutdown_waits_for` example doesn't work as intended

In the readme the following example is given:

import asyncio
from aiorun import run, shutdown_waits_for

async def corofn():
    await asyncio.sleep(60)
    print('done!')

async def main():
    try:
        await shutdown_waits_for(corofn())
    except asyncio.CancelledError
        print('oh noes!')

run(main())

With the explanation:

If you hit CTRL-C before 60 seconds has passed, you will see oh noes! printed immediately, and then after 60 seconds (since start), done! is printed, and thereafter the program exits.

I’m finding that this isn’t the case. The program never actually exits on its own.

(Also there’s a missing : on the end of the asyncio.CancelledError)

[cjrh]

Yep:

import asyncio

async def main():
    try:
        ...  # do your stuff here
    finally:
        asyncio.get_running_loop().stop()
    
run(main())

By simple stopping the loop, the graceful-shutdown procedures inside aiorun will take over, cancel all pending tasks etc.

If this resolves it, pls feel free to close the issue 👍🏼

[Fuzzwah]

Gotcha. Sorry, I misunderstood that part of the readme.

Is there a way I can “nicely” make a aiorun.run() process exit? While I’m testing my script using CTRL-C is excellent, but now that I’m looking to rig my python script up as a linux service I’m looking for a way to be able to trigger a halt in a nice way.