OnDestroy shouldn't set the FormControl value to null

The ngOnDestroy method

public ngOnDestroy(): void {
  this.fg = null;

  if (this.subscription) {
    this.subscription.unsubscribe();
  }

  if (this.onChange) {
    this.onChange(null);
  }
}

currently sets the original FormControl value to null. I’d say it’s not really the responsibility of the library to set that value to null, thus

if (this.onChange) {
  this.onChange(null);
}

should be removed.

[fadisdh]

Thank you, this helped a lot with tabbed forms (as I don’t want to lose the data whenever the tab gets changed and components get destroyed)

Didn’t find documentation for it though, saw the closed issue while trying to write a new one. can you please add it in the Readme file? Thx again 😃

[maxime1992]

@fadisdh you can track the new issue here

https://github.com/cloudnc/ngx-sub-form/issues/56