Hook to be warned when the form has changed?

I think that a very common thing with form is subscribing to the form value and also start that observable with the current form value.

Example of doing that with this lib:

this.formGroup.valueChanges
      .pipe(
        startWith(this.formGroupValues),
        tap(() => this.doSomething())
      );

Annoying part is that in doing so, we have to manage the subscription and the cleanup when the component’s being destroyed.

I wonder if it would be worth having a method taking care of the whole observable/async part so that to react to a form change we would only need to do something like that:

@MyComponent({...})
class MyComponent extends NgxSubForm<FormInterface> {
  protected getFormControls(): Controls<FormInterface> {
    return {...};
  }

  protected onFormUpdate({ formValue, isInitialValue }: FormChange<FormInterface>) {
    // do something with formValue, also possible to make a condition if you don't want
    // to react to the initial value
  }
}

@zakhenry what do you think?

[zakhenry]

Oh oops I only saw the first example, yea I guess is initial is sufficient

On Wed, 15 May 2019 at 8:57 am, Maxime [e-mail] wrote:

We should pass the index number so the inheriting class can ignore the first call if they want

Within my example I’ve got protected onFormUpdate({ formValue, isInitialValue }: FormChange<FormInterface>) do we really need to know the index? My initial thought was that isInitialValue (boolean) would be enough

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cloudnc/ngx-sub-form/issues/34?email_source=notifications&email_token=AAFQE2N52UMCCKUPIUJMEOTPVO667A5CNFSM4HNAQUR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVN3EXY#issuecomment-492548703, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFQE2ODGSO5LPVLUHCFGMTPVO667ANCNFSM4HNAQURQ .

– Zak Henry

[maxime1992]

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀