Change way how we configure docker registries

Today to configure custom docker registries and docker registries for aws ecr we require user to fill really tricky multi line property like:

$docker_registry_credentials = "registry1.url=my-private-registry1.com:5000
registry1.username=corp_user1
registry1.password=corp_pass1
registry2.url=my-private-registry2.com:5000
registry2.username=corp_user2
registry2.password=corp_pass2"

This approach will not work with codenvy in docker containers where we configure everything with ENV variables.

My proposal is to configure only path to the file like:

$docker_registry_credentials = "/path/to/file.properties"

Where user will define his settings according to docs, then we check if user set path to his file we will volume mount this file to our server same as we are doing for all configs.

[riuvshin]

Ok It seems I’ve found a way. I figured out how to take any amount of ENV vars by contains some key and propagate those ENV vars from codenvy.env to codenvy environment file which will used by codenvy tomcat, using this way we don’t need property files at all, we configure codenvy tomcat via it own ENV vars. So in that approach user will need only add to codenvy.env ENV vars like

CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_ID_1=id_for_resgistry1
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_REGION_1=region_for_resgistry1
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_ACCESS_KEY_ID_1=access_key_id_for_resgistry1
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_SECRET_ACCESS_KEY_1=secret_access_key_for_resgistry1

CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_ID_2=id_for_resgistry2
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_REGION_2=region_for_resgistry2
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_ACCESS_KEY_ID_2=access_key_id_for_resgistry2
CODENVY_DOCKER_REGISTRY_AWS_ECR_CREDENTIALS_SECRET_ACCESS_KEY_2=secret_access_key_for_resgistry2

So using other words we will just send ENV varsf from codenvy.env to codenvy tomcat which should respect ENV vars same as a props and we are good.

I thought with puppet I can’t do that but I figured out how with Ruby injections.

WDYT guys?

[riuvshin]

@garagatyi Done. changes: https://github.com/eclipse/che/commit/d09dd3c5c43440aadc6c0424cf39585add1dec31 https://github.com/codenvy/codenvy/commit/e36836ea5179d80147bf91be9aed0c20327479a6

Aws credentials does not work yet due to: https://github.com/eclipse/che/issues/2454