plugin-regexp/remove-useless-group should not remove groups in `.split()` or `.replace()`

plugin-regexp/remove-useless-group changes:

'lala'.split(/(a)/g); // Output: ["l", "a", "l", "a", ""]

into:

'lala'.split(/a/g); // Output: ["l", "l", ""]

It also changes:

'lala'.replace(/(a)/g,'-$1-'); // Output: "l-a-l-a-"

into:

'lala'.replace(/a/g,'-$1-'); // Output: "l-$1-l-$1-"

This plugin is safe to use in .test(), but should likely ignore regex that appears in any other function (match, split, replace).

[egilll]

Wonderful, now works correctly when inside of a split or replace. There are three other situations I’ve been able to find where this results in changing the output:

1. Standalone regex

// Before
const r = /(a)/g;
"lala".split(r);  // Output: ["l", "a", "l", "a", ""]

// After
const r = /a/g;
"lala".split(r); // Output: ["l", "l", ""]

1. exec()

// Before
/(a)/g.exec("haha"); // Output: ["a", "a"]

// After
/a/g.exec("haha"); // Output: ["a"]

1. replaceAll()

// Before
"lala".replaceAll(/(a)/g,'-$1-'); // Output: "l-a-l-a-"

// After
"lala".replaceAll(/a/g, "-$1-"); // Output: "l-$1-l-$1-"

A possible solution (in particular to the standalone regex) might be to whitelist regex that is:

• Directly followed by .test()
• Directly followed by .search()
• Inside of .match()

instead of blacklisting?

(By the way, this is a great project that I’ve been much in need of!)

[coderaiser]

Landed in @putout/plugin-regexp@2.8.0 🎉 . Is it works for you?