Components - IconsSee original GitHub issue
All icons & color codes can be found on the Sketch cloud: https://sketch.cloud/s/xVR5A/paKjK7A
Given that we are going to use our own custom svg icons, we need to remove
@fortawesome from our dependencies: https://github.com/Coding-Coach/coding-coach/blob/develop/package.json#L28-L31
We already have an
Icon component to render svg icons, let’s use this approach for all new icons.
This task also includes migrating the current icons in the home page from
fortawesome to the new
Icon component that we have.
Edit: The design contains two states for the icons (active, inactive), that should be handled by the navigation component (We don’t have it yet), this task doesn’t include that. Only adding the icons to our icons catalog, we might want to create a storybook for all the available icons we already have.
- Created 5 years ago
- Comments:25 (6 by maintainers)
Top GitHub Comments
Sorry for the delay, had a very sick 6 month old so haven’t progressed as quick as I thought!
Will get this pushed ASAP!
(Feel free to move it to someone else, i’d 10000% understand)