Remove .env file from .gitignore to ease installation & setup

Currently after cloning, users have to remove the .example extension from the .env file. This is annoying. Let’s just remove .env from the .gitignore.

[darrenvong]

Thought I’d leave a reference to facebook/create-react-app#2403 as it seems relevant to this discussion, where Dan Abramov supports committing .env file for convenience and the fact you can’t store real secrets in the client app.

[trent-boyd]

I’d like to take this!

I kind of agree with @jagzviruz. .env files are usually for things that might change on a per-environment basis, but we’re kind of using them as a dictionary. I don’t think our social links need to be there, so could we just keep them defined in constants.js?

social: {
  // we could just remove everything before and including the ||
  FB_URL: process.env.REACT_APP_FACEBOOK_URL || 'https://www.facebook.com/codingcoachio/',
  INSTA_URL: process.env.REACT_APP_INSTA_URL || 'https://www.instagram.com/codingcoach_io/',
  TWITTER_URL: process.env.REACT_APP_TWITTER_URL || 'https://twitter.com/codingcoach_io',
  GITHUB_URL: process.env.REACT_APP_GITHUB_URL || 'https://github.com/Coding-Coach/coding-coach',
},

For the remaining variable (NODE_PATH), we could leave it defined there or prefix all our our scripts with it in package.json (e.g. "build:app": "react-scripts build" becomes something like"build:app": "cross-env NODE_PATH=src/ react-scripts build"). It’s a little verbose to have it defined so many times, so I’m open to more input on that.