Crash (infinite loop?) in visualize_qtree

I don’t know the cause of this yet but there is a crash in visualize_qtree.

I think it’s hitting an infinite loop somewhere but I haven’t been able to find where yet. It seems to happen near the top of the canvas when you only have one point near the edge of the circle.

Just adding this as a placeholder. Will continue looking for the infinite loop.

EDIT

OK, found it.

In quadtree.js, closest function.

If point has 0 points with the maxDistance then, during the binary search the inner radius will get asymptotically close to maxDistance but limit is never adjusted and so the search will never end.

Creating a PR for it now.

[crhallberg]

Thanks for cleaning up both the inconsistencies (width vs. width/2 and also <= vs <)!

I’m going to give this a closer look but I think the PR is almost set. I left a couple of comments.

[oliver-foggin]

Let me have a play and see if I can come up with something.