string-strip-html: removes <%= %> tags

Package’s name

string-strip-html@8.0.1

Describe the bug

string-strip-html is removing <%= %> tags along with everything inside them.

To Reproduce

const {stripHtml} = require('string-strip-html')

const plaintext = stripHtml('<div>My variable: <%= @var %></div>').result

This outputs: My variable:

Expected behavior

Should output: My variable: <%= @var %>

Additional context

Reported in https://github.com/maizzle/framework/issues/394 where we currently use v7.0.2, but I’ve just tested with v8.0.1 and the bug is still present.

P.S.: it’s great to have you back here 🥳

[revelt]

It’s already fixed on local, I’m aiming to release this weekend. Algorithm wise, I DRY’ed up all asserts on "<" (assumption that tag should start here) or ">" (assumption that tag would end here) into separate functions, then beefed them up at that single location with checks, do % precede/follow. Originally, I had added the check against % following a single opening, on only one clause, inline. Now it’s checking everywhere, properly. It’s a good future-proof measure, we’ll be able to supplement more templating language types that way. Maybe another templating language like <$... $> or something…

[revelt]

on it. sorry about that