Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Crushing html produces unwanted "empty lines filled with whitespaces"

See original GitHub issue

Package’s name html-crush (4.1.4)

Describe the situation Here is a Simple example to reproduce my problem. It should be self explanetory 😃

const { crush } = require("html-crush")

const input = `<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
</head>
<body>
  <div>Hello</div>
</body>
</html>
`

const output = crush(input, {
  removeLineBreaks: true,
  removeIndentations: true,
  removeHTMLComments: true,
  removeCSSComments: true,
})

output.result === `<!DOCTYPE html>

<html lang="en">

<head>
  
<meta charset="UTF-8">
  
<meta http-equiv="X-UA-Compatible" content="IE=edge">
  
<meta name="viewport" content="width=device-width, initial-scale=1.0">
  
<title>Document</title>

</head>

<body><div>Hello</div>

</body>

</html>
`

Is there something I’m doing wrong?

I would like the result to be compacted with no extra newlines/whitespaces, until the line length is reached…

Issue Analytics

State:
Created 2 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

reveltcommented, Apr 3, 2021

It should be fixed in 4.1.7 released an hour ago, please confirm

1reaction

reveltcommented, Apr 1, 2021

I think I found the source, the CJS build, during Rollup+Babel somehow omits the spread operator which changes the logic of the program. However, the ESM and UMD builds are fine! That threw me off track at the beginning… Only CJS, CommonJS builds are not working as intended. What’s crazy is that it’s a real bug somewhere in Babel, or rather its config… I’ll nail this very soon.

@SylannBin, thank you for flagging this up! I’ll write up an article what went wrong and publish and credit you for the find.

Again, sorry for the bug.

It’s a shitty situation, I did all my best, unit tests passed (on ESM), it’s just Babel and/or Rollup produced a bad output which they should not have produced. But I’m “responsible” for the library in the end… Do you see? The bundlers should not even allow broken code, they should be smart-enough to alert us! Anyhow, I plan to release a patch this weekend.

Sorry about this.