Web code style: Use async/await?

Would you like to try changing the coding style from using Promise.then into async/await? Thanks

One example of change (on src/lib/api.ts):

private getRandomSentences(count: number): Promise<string[]> {
  return this.getSentences().then(sentences => {
    let randoms = [];
    for (var i = 0; i < count; i++) {
      let distribution = Random.integer(0, sentences.length - 1);
      let randomIndex = distribution(this.randomEngine);
      randoms.push(sentences[randomIndex]);
    }
    return randoms;
  });
}

become:

private async getRandomSentences(count: number): Promise<string[]> {
  const sentences = await this.getSentences();
  let randoms = [];
  for (var i = 0; i < count; i++) {
    let distribution = Random.integer(0, sentences.length - 1);
    let randomIndex = distribution(this.randomEngine);
    randoms.push(sentences[randomIndex]);
  }
  return randoms;
}

[mikehenrty]

We are now using async/await in multiple places, and will continue to use it going forward. Let’s incrementally switch to this new API when we touch parts of the code rather than doing large refactorings.

With that in mind, I’m closing this bug as we won’t have separated work for this.

[mikehenrty]

Is there any particular reason for (keeping on) using bluebird? Or could we switch the server code to plain ES6 Promises as well?

I’m fine with removing bluebird now that we are targeting es6.