Custom author name breaks when it's a template

Summary:

The custom author name setting expects a username, unlike for example the similar field in UploadWizard. For example, when setting a custom author name that contains a template, it is wrapped in a User link.

For example, this revision contains:

|author=[[User:{{User:Samwilson/photographer|camera=g6}}|{{User:Samwilson/photographer|camera=g6}}]]

Steps to reproduce:

1. Set a custom author name to a non-username string.
2. Upload a photo.
3. View the photo on Commons and look at the author= field.

It should only treat the custom author name as a username if it actually is. I’m not sure how UploadWizard does it, but the feature works well there.

Device and Android version:

• LG G6

What make and model device (e.g., Samsung J7) did you encounter this on? What Android version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it the stock version from the manufacturer or a custom ROM ?

Commons app version:

• 2.11.0~93b948d20

Would you like to work on the issue?

No.

[samwilson]

@misaochan thank you! that worked, now it’s uploading properly again! And no, the logs weren’t empty, but all they had for the current day was e.g. [file-logging-thread-1] [ContributionsSyncAdapter] : Received image File:2019-07-12 Fremantle Bowling Club, 4.jpg and nothing about uploading.

Anyway, the issue at hand still exists; custom author names can’t contain templates.

[samwilson]

The string I get the bug with is {{User:Samwilson/photographer|camera=g6}}, i.e. anything that’s not a username, because the app then takes that string and puts it into [[User:x|x]] (where x is the string).