question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Merge Structured Data branch into master

See original GitHub issue
  1. Clone this repository somewhere on your computer: https://github.com/VitalyVPinchuk/apps-android-commons/tree/upload_caption_depict
  2. Switch to the upload_caption_depict branch
  3. Test it: Browse by items, see parent and child items
  4. Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture
  5. Merge the latest master of git@github.com:commons-app/apps-android-commons.git
  6. Fix the conflicts
  7. Test again (steps 3 and 4)
  8. Let us know when you are done by posting a comment below

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:58 (48 by maintainers)

github_iconTop GitHub Comments

2reactions
nicolas-raoulcommented, Mar 11, 2020

@macgills I have thousands of pictures to upload, here are some just for you, after you upload them all please please ask and I will add a hundred more 😃

2reactions
misaochancommented, Mar 10, 2020

@macgills Wow, sorry, I didn’t get notified of this ping for some reason! Could you please link me to the image on Commons that you uploaded with this branch? The caption and depicts fields should be appropriately filled in the Commons file page.

subsequently a crash when clicking the 2nd item but that bug was introduced in #3133.

How did #3133 introduce a new crash?

Aside from that, here are the issues with the branch that I can see so far:

From @maskaravivek :

Apart from resolving the merge conflicts, this task would also require fixing the Wikidata API calls. None of the authenticated API were working earlier.

Also, the URLs are correct AFAIK, but some changes need to be done in how the edit token is fetched. Also, some of the APIs need to be modified to send multipart request params instead of application/x-www-form-urlencoded.

From @nicolas-raoul :

Test it: Browse (Explore) by items, see parent and child items Test it more: Upload a picture via Nearby and post below the URL of the uploaded picture Merge the latest master of git@github.com:commons-app/apps-android-commons.git Fix the conflicts Test again (steps 3 and 4) Let us know when you are done by posting a comment below

From @GearGit :

Whenever I am searching for some caption under items -> media tab, “No images found” message is displayed for any caption that I enter, but if I enter same caption under the media tag then it works fine. Furthermore, when I am checking the parent and child classes, then I am sometimes encountering the following leak:

Also, for an easy-to-read summary of what the PR is supposed to do, you can read this: https://medium.com/@vanshikaa937/google-summer-of-code19-final-post-d78e601ea39d . I think it’s OK for this task to take you 1-2 weeks, if the final result is a polished implementation of depicts and captions in our upload process and Explore feature.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I safely merge a Git branch into master?
Git Alias · master To create a new branch, we can use the git branch new-branch command. This will create a new branch...
Read more >
How GitLab developers can merge any branch into master
Only users in the developer or maintainer role in GitLab can merge branch into master or push a GitLab branch into master.
Read more >
How To Structure Your Git Branching Strategy — By A Data ...
The UAT branch is merged into the MASTER branch through a pull request. CI/CD deploys A, B, and C onto the Production environment....
Read more >
Branching and Merging with GitKraken Client | Git Branching
Merging takes the commits on two different branches and combines them. With a merge, files are automatically merged unless there are two conflicting...
Read more >
Recommended git workflow — GPCRdb 1 documentation
While you work on your branch, other developers may push their commits to the master branch. It is important that you keep your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found