Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

getCommitHash is an unreliable proof that _prevPollID exists

See original GitHub issue

In commitVote, we check to ensure that the insert position (_prevPollID) actually exists by checking getCommitHash(msg.sender, _prevPollID) != 0. If a user sets their commit hash for that poll to zero, that check will fail even though it is a valid insertion position.

Recommendation

Use DLL.contains to verify that _prevPollID is a valid insertion position.

Issue Analytics

State:
Created 6 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

kangarangcommented, Mar 5, 2018

i love you

0reactions

kangarangcommented, Mar 27, 2018

https://github.com/ConsenSys/PLCRVoting/commit/1fec53b876156d8f219d09c5bc871e83c14b4fee

Top Results From Across the Web

TCR Audit Report by ConsenSys Diligence - GitHub

3.2 - getCommitHash is an unreliable proof that _prevPollID exists. Severity: Major. In commitVote , we check to ensure that the insert position ......