pollEnded returns true when invoked with pollIDs of non-existant polls

    it('should throw an error if the poll does not exist', async () => {
      const plcr = await utils.getPLCRInstance();

      const options = defaultOptions();
      options.actor = bob;

      try {
        const ended = await plcr.pollEnded.call('9001'); // this returns true
        assert(false, 'should have thrown error for non-existant poll #9001');
      } catch (err) {
        assert(utils.isEVMException(err), err.toString());
      }
    });

[skmgoldin]

Good advice @yorhodes. We decided to add an explicit function for it. Doing it in isExpired seemed slightly non-idiomatic to that function’s purpose.

https://github.com/ConsenSys/PLCRVoting/commit/b1a05e8ace28a5a6b991ba0435389a4dd73568b8

[kangarang]

Indeed, implementing the check in isExpired is cleaner, and all tests pass.

function isExpired(uint _terminationDate) constant public returns (bool expired) {
    require(_terminationDate > 0);
    return (block.timestamp > _terminationDate);
}

I like this solution! @skmgoldin, how should we proceed?