Setting a choice in updateParameters causes the DAV plugin to be enabled

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package`
  • Checked the FAQs: https://github.com/constellation-app/constellation/faq
  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/repositories-catalog

Description

Setting a choice in updateParameters in a Data Access View (DAV) plugin will fire an event and cause the plugin to be enable. For example refer to ExtractFromContent or SplitNodesPlugin which have this issue and so for now, the setChoice logic has been commented out.

Steps to Reproduce

1. Open the Data Access View
2. Open a graph

Expected behaviour: No plugin is active

Actual behaviour: The Extract from Content plugin or Split Nodes plugin is enabled in the DAV

Reproduces how often: 90%

Additional Information

The issue currently does not occur because the relevant code is commented.

[aldebaran30701]

Recreation of this issue from my experience is from doing the following:

1. open constellation
2. open DAV
3. open new analytic graph
4. expand split nodes plugin a. select “correlation” b. uncheck split nodes plugin
5. close graph
6. open new analytic graph

These steps seem to reproduce the issue 100% of the time thus far. “split node plugin” and “extract from … plugin” seem interchangeable with these steps and produce the same result.

NOTE: The issue is still persistent even with the code commented out. the current release will produce the issue when following the steps above.

[arcturus2]

@aldebaran30701 nice work on the reproducer. I didn’t realise this was happening with that code commented out. Are you still ok to look into this when you can?

If so and say you need to make a change that requires updates to the 2 existing plugins, that is fine too. I’m relying on other developers reading CHANGELOG.md as the primary way to communicate to them that they need to be aware of changes that could affect them in their modules dependant off Constellation (“Core”).