Timeline summary window box can shrink unexpectedly

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Running the latest version of Constellation
  • Attached the Support Package via Help > Support Package`
  • Checked the FAQs: https://github.com/constellation-app/constellation/faq
  • Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
  • Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/repositories-catalog

Description

Dragging the Timeline’s summary window box toward the right edge of the summary window will cause it to jump around and in the process slowly shrink.

Steps to Reproduce

1. Create a sphere graph
2. Open the timeline view, making sure the summary window is visible
3. Drag the box in the summary window to the right edge
4. Keep trying to drag the box across and notice the timeline jump around and the box slowly shrink

Expected behaviour: Summary window box is not affected by forcing box beyond current summary window bounds Actual behaviour: Summary window box shrinks when trying to go past summary window bounds

Reproduces how often: 100%

Additional Information

The main effect of this bug is that it acts as an unexpected zoom in

[antares1470]

I finally worked it out, going one step up the function chain from performDrag() you get the following function:

private void handleDragging(final MouseEvent t) {
     //Resize POV if necessary:
     if (isResizingLeft || isResizingRight) {
          resizePOV(t);
     } else { // If we aren't resizing we are dragging:
          // only drag on 'x' press:
          performDrag(t);
     }

     // Update the origin as we have had some movement:
     origin = t.getX();
}

The issue here ends up being the final line which assumes that there has been movement when actually movement only occurs if it meets the boolean conditions within the functions. Since origin was used to help determine how far we have moved, this incorrect assumption from the last line of the above function is what is causing the problem.

Moving this line to within the if conditions of the functions it calls seems to fix the issue

[antares1470]

performDrag() in OverviewPanel is where it is determined whether or not dragging the summary box should be done. Whether it is done or not is determined by the following if condition in the function:

// Only perform drag if it is within the bounds of the histogram:
if (0.0 <= newX && (newX + rect.getWidth()) < histogram.getWidth()) {...

I don’t think there is an issue with the if condition as this is used elsewhere and makes sense. What I have discovered during debugging though is that histogram.getWidth() may be changing value unexpectedly. This function will run multiple times depending on the size of the drag but every time the if condition evaluates to true this results in the histogram width changing somehow and I’m unsure as to why or how. Someone with more knowledge in this may be able to explain more as to what is actually being measured for the histogram width but my understanding is that it shouldn’t be changed by this.