FontAwesome TTF is distributed with ControlsFX JAR, JavaDoc says it is not

The JavaDoc of org.controlsfx.glyphfont.FontAwesome says:

Note that at present the FontAwesome font is not distributed with ControlsFX, and is, by default, instead loaded from a CDN at runtime.

But now the “fontawesome-webfont.ttf” IS distributed in the ControlsFX JAR: here.

JavaDoc should be revised.

[aalmiray]

Supporting JDK8 and JDK11+ is not a trivial task as there are binary breakages since JavaFX 9 (CSS api has been moved from private to public for example). Also all artifacts provide a module-info.java file that can only be compiled with JDK9+.

Plugins like moditect could help in generating the module descriptors even of JDK8 is used. Ideally we could build MRJARs but Gradle’s support for it is dismal at best. Now that I think of it MRJARs would not work as the ikonli-javafx artifact must have explicit dependencies on the JavaFX APIs, which are distributed differently since JDK11 thus 2 distinct artifacts must be published.

Let me think about this as it’s mostly a build problem.

[dlemmermann]

No, it works for 8 and 11.

Alexander Krimm [e-mail] schrieb am Do. 31. Okt. 2019 um 22:10:

Ikonli looks really nice, but seems to require jdk11 at minimum: aalmiray/ikonli#44 https://github.com/aalmiray/ikonli/issues/44

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/controlsfx/controlsfx/issues/1195?email_source=notifications&email_token=ACIXWXL5QJESSA7NSONV2WLQRNCVNA5CNFSM4JAHAFNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZIIUA#issuecomment-548570192, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIXWXK7GI2TMQFEXRA3IB3QRNCVNANCNFSM4JAHAFNA .

– Dirk Lemmermann

Software & Consulting Zurich, Switzerland [phone] http://www.dlsc.com mailto:[e-mail]